Code Monkey home page Code Monkey logo

Comments (6)

chimbori avatar chimbori commented on August 24, 2024

Sounds like a good idea! The way I would like to think about this is,

  • There are already many users of this library that depend on JSoup & OkHttp, so moving to KSoup & Ktor should not be forced upon them. A separate published library (different coordinates) would be good, so that those that depend on the existing JSoup + OkHttp + Crux stack can continue to receive updates.
  • We should aim to have tests that ensure that the output from both is the same. KSoup is still maturing, and there may be behavior changes from JSoup.

from crux.

LaatonWalaBhoot avatar LaatonWalaBhoot commented on August 24, 2024

Would it not make it difficult to maintain?
Having to provide feature updates to both libraries? As far as I understand if we can achieve consistent behavior then dependents won't have any issues no?
Agree on the tests part.

from crux.

chimbori avatar chimbori commented on August 24, 2024

Crux exports both Jsoup and OkHttp as API dependencies, and also returns native JSoup objects. So moving to KSoup will be a breaking change for all clients.

Since many clients already use JSoup, we cannot reasonably expect everyone to fully move over to KSoup, even after it reaches full maturity.

from crux.

LaatonWalaBhoot avatar LaatonWalaBhoot commented on August 24, 2024

Do I publish the KMP library separately from this?
I will link it to Crux and give credits.
Or is there an alternative that you can propose since functionality will be almost similar?

from crux.

chimbori avatar chimbori commented on August 24, 2024

It’s possible to have two or more separate libraries published from the same repo; that seems like a preferable approach so that everything stays in one place, and still can be optionally imported by clients.

from crux.

LaatonWalaBhoot avatar LaatonWalaBhoot commented on August 24, 2024

@chimbori Have raised PR #30. Please take a look

from crux.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.