Comments (6)
Sounds like a good idea! The way I would like to think about this is,
- There are already many users of this library that depend on JSoup & OkHttp, so moving to KSoup & Ktor should not be forced upon them. A separate published library (different coordinates) would be good, so that those that depend on the existing JSoup + OkHttp + Crux stack can continue to receive updates.
- We should aim to have tests that ensure that the output from both is the same. KSoup is still maturing, and there may be behavior changes from JSoup.
from crux.
Would it not make it difficult to maintain?
Having to provide feature updates to both libraries? As far as I understand if we can achieve consistent behavior then dependents won't have any issues no?
Agree on the tests part.
from crux.
Crux exports both Jsoup and OkHttp as API dependencies, and also returns native JSoup objects. So moving to KSoup will be a breaking change for all clients.
Since many clients already use JSoup, we cannot reasonably expect everyone to fully move over to KSoup, even after it reaches full maturity.
from crux.
Do I publish the KMP library separately from this?
I will link it to Crux and give credits.
Or is there an alternative that you can propose since functionality will be almost similar?
from crux.
Itβs possible to have two or more separate libraries published from the same repo; that seems like a preferable approach so that everything stays in one place, and still can be optionally imported by clients.
from crux.
@chimbori Have raised PR #30. Please take a look
from crux.
Related Issues (18)
- Exception in thread "main" java.lang.NoClassDefFoundError: com/chimbori/crux/articles/ArticleExtractor HOT 1
- images, videos, iframes HOT 1
- [NEWYORKER] Span tags are replaced with a paragraph tag HOT 1
- Mark certain nodes to be kept: `crux-keep` HOT 1
- page the fails badly HOT 1
- New Release? HOT 3
- Release to Maven Central HOT 11
- Article publication date
- Use default values with Article data class HOT 4
- Why not use Uri.parse or String instead of OkHttp? HOT 5
- Unable to write custom plugin since Plugin interface is sealed HOT 2
- Crux replaces page title with site title. HOT 1
- the extracted content output not contain picture elements HOT 8
- Preserve <br>? HOT 4
- Missing content for NYT recipe
- Hidden popup chosen as article HOT 5
- [NYT] Content after ad is not extracted
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crux.