Hotkey scoping about angular-hotkeys HOT 5 CLOSED

Agree. Did you encounter this where you could let me know a simple scenario I can add to the tests? Generally, controllers get destroyed when changing routes (which will destroy the hotkey), but if there are cases where destroying controllers happens without a route change, then this should definitely be addressed.

from angular-hotkeys.

After thinking about this more, I don't think there are many normal cases where controllers are destroyed without a route change. Really the issue is that I am using the UI Router instead of the Angular Router. I think I saw someone was working on the UI Router update to this library so I am fine waiting for that.

from angular-hotkeys.

I can think of a couple cases where a controller might be destroyed outside of a route change: ngInclude, ngIf... basically anything where the DOM node is removed. See: http://plnkr.co/edit/KytBilQzg2XxZ8ZkaSPt?p=preview

from angular-hotkeys.

The another example could be Modal windows (angular-bootstrap modal component)

var modal = $modal.open({
                   ...
                    templateUrl: '/my-selection-dialog.tpl.html',
                    controller: FromExistentModelCtrl,
                    resolve: {
                          ....
                    }
                });

So the window is created and destroyed within same route/state, but window actions are handled by separate view controller.

Although I think that binding hotkeys in directives could be a solution for most case

from angular-hotkeys.

So from what I can tell, there's no good way for the service to be informed automatically of the controller's scope being destroyed. In order to accomplish this, I had to add an additional method which passes the controller's scope into the service, at which point, hotkeys will automatically take care of removing the bindings when the scope is destroyed. It looks like this:

angular.controller('MyCtrl', function ($scope, hotkeys) {
  hotkeys.bindTo($scope)
    .add({
      combo: 'w',
      description: 'blah blah',
      callback: function() {}
    })
    // you can chain these methods for ease of use:
    .add ({...});

});

You can check out the i32-scope-destroyed branch to see and play with it for yourselves. If anyone can think of a better way, please let me know...otherwise I'll merge this into master and call it complete.

from angular-hotkeys.