Code Monkey home page Code Monkey logo

Comments (7)

chieffancypants avatar chieffancypants commented on June 24, 2024

First of all, that is an excellent sombrero and I applaud your profile picture.

secondly, (and maybe more importantly), I guess I viewed controller defined hotkeys as being persistent because people using them likely aren't using them in conjunction with routes. You raising the issue means this may not be the case. Can you help me with a use-case so I can wrap my brain around such things?

from angular-hotkeys.

maxbates avatar maxbates commented on June 24, 2024

My feeling was (could be totally wrong, but at least for people using ngRoute - though don't know what fraction that is anymore) that most controllers are tied to a view, and in most cases that meant instantiated on a route change. I realize that may not be the case for others, but I have built several simple apps around that idea.

I would be happy with a provider config option to not persist them by default...

from angular-hotkeys.

ameswarb avatar ameswarb commented on June 24, 2024

+1, I feel that if anything persistence should be manually declared

from angular-hotkeys.

wmbutler avatar wmbutler commented on June 24, 2024

+1, I agree. The sombrero rocks. Additionally I agree that it would be nice to exit a route and then have the hotkey continue to work once returning to said route. I was so excited to see that the hotkeys could be defined at the route level. I'm going to wire it up to the controller for now but will switch it out if you decide to add this.

from angular-hotkeys.

chieffancypants avatar chieffancypants commented on June 24, 2024

Hotkeys defined by routes are not persistent so it sounds like your usecase
will work without modification.

from angular-hotkeys.

wmbutler avatar wmbutler commented on June 24, 2024

Hmmm,

When I first call the route everything works but when I leave the route and
return, it stops working. I solved the problem by binding to scope in the
controller.

On Wed, Jul 9, 2014 at 11:35 AM, Wes Cruver [email protected]
wrote:

Hotkeys defined by routes are not persistent so it sounds like your usecase
will work without modification.


Reply to this email directly or view it on GitHub
#11 (comment)
.

Bill Butler
[email protected]
(615) 330-5044

from angular-hotkeys.

chieffancypants avatar chieffancypants commented on June 24, 2024

Sorry for the delay here, I'm trying to clean up old tickets. This scenario is likely possible using the newer bindTo syntax

from angular-hotkeys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.