Code Monkey home page Code Monkey logo

Comments (14)

pynner avatar pynner commented on June 1, 2024 1

Prevent cursor from changing to text cursor when hovering over text. This thing -> GitHub Logo

from phat.

jsbrn avatar jsbrn commented on June 1, 2024 1

The shadows definitely make it pop @scs97liu

from phat.

chgibb avatar chgibb commented on June 1, 2024

In what situations is this undesirable @pynner ?

from phat.

pynner avatar pynner commented on June 1, 2024

I don't think there is currently a desirable situation for the text cursor, if you mouse over any of the table headers in QC it will change to the text cursor. Since the user can't change any of that text, could be confusing/unintended.

I noticed it most on my patch, I want users to click on 'click to analyze' but with cursor changing to the text cursor it was misleading for sure.

from phat.

jsbrn avatar jsbrn commented on June 1, 2024

I want users to click on 'click to analyze' but with cursor changing to the text cursor it was misleading for sure.

Why not just change it to a button? Seems like that would be easier.

from phat.

pynner avatar pynner commented on June 1, 2024

Why not just change it to a button? Seems like that would be easier.

It would be easier but, I'm not enough of a js wiz to swap an img(button) with progress text when working with the file validIDs.

from phat.

jsbrn avatar jsbrn commented on June 1, 2024

What if we stylized it to look like a typical HTML link?

from phat.

chgibb avatar chgibb commented on June 1, 2024

If you're thinking of just disabling the cursor change over certain text it should be fairly easy @pynner

from phat.

jsbrn avatar jsbrn commented on June 1, 2024

So I attempted to add a button for each input on the QC summary screen, but didn't get far. @chgibb can you look at my commit? Specifically, how do you think the button should be attached to the current functionality.

from phat.

chgibb avatar chgibb commented on June 1, 2024

@jsbrn @pynner please see #122 . Let's centralize all our discussion and commits about QC UI improvements there. Make PRs against that branch.

from phat.

RobJackson28 avatar RobJackson28 commented on June 1, 2024

Hey @scs97liu, @chgibb just showed me some new mockups of the UI design and I have a couple thoughts:

  1. I really like the mouse-over shadow effect, that's awesome!
  2. I like the background colour
  3. The title doesn't fit so well, likely due to the colour (dark text on blue background), as well as it is already given in the Toolbar, so may not need to be reiterated.
  4. You may want to consider adding a little bit of space between the buttons, just a couple more pixels I think would look better.
  5. I'm not sure how I feel about the thin black border around the rounded edges of the buttons. Do you think this could look better either with a full border around the whole button, or no border perhaps (since the mouse-over effect gives a good distinction from the background).
  6. The design within the buttons looks very slick, but you may need to use a thicker font for the "QC" and "ALIGN" titles, a bit too hard to see.

from phat.

chgibb avatar chgibb commented on June 1, 2024

We surveyed a few members of the lab for feedback about the toolbar. Consensus seems to be that we're moving forward relative to what it used to look like. In addition to what @RobJackson28 said, some issues with contrast and too much blue was brought up. I would suggest we start to use something like NinjaMock or Invision in order to more rapidly iterate on design prior to implementing it.

from phat.

scs97liu avatar scs97liu commented on June 1, 2024

With regard to too much blue. I usually prefer design to have a consistent color scheme. We could maybe throw in a few other colors which complement blue? But we would have to see where we could add in a different splash of color.

from phat.

RobJackson28 avatar RobJackson28 commented on June 1, 2024

I like blue. It's my favourite colour! Though, we definitely want to use a nice crisp and minimalist style, so a white background may work, or slightly grey.

from phat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.