Code Monkey home page Code Monkey logo

Comments (6)

giovannialbero1992 avatar giovannialbero1992 commented on June 9, 2024 1

Ah ok I got it.
it makes sense

from core.

nicola-corbellini avatar nicola-corbellini commented on June 9, 2024

Correct me if I'm misunderstanding, but I'm not sure adding it before the parsing happens is the right place.
At that point, you have file bytes and you should parse them to remove the noise.

Hence, you could post process the text before the rabbit hole splits the text or inside the parse itself.
In the last case, you could override the BeautifulSoup parser and perform parsing and post processing all at once

from core.

giovannialbero1992 avatar giovannialbero1992 commented on June 9, 2024

Hi @nicola-corbellini, at that point the HTML for example is already stripped, so I can't do parsing to remove noise based on some tag or attribute.

from core.

nicola-corbellini avatar nicola-corbellini commented on June 9, 2024

Ah my bad, didn't think about that. Than a custom parser is the best solution, I think.
We are relying on Langchain, which, in turn, uses BeautifulSoup (ref here).
Maybe tuning some params could be enough, but implementing a new one guarantees full control.

from core.

giovannialbero1992 avatar giovannialbero1992 commented on June 9, 2024

If you agree I could do a proposal on this ;-)

from core.

nicola-corbellini avatar nicola-corbellini commented on June 9, 2024

Mmm ok...in my mind the solution was to just make a plugin with your own parser and replace the default one with the rabbit_hole_instantiates_parsers hook, but if you have a proposal I'm happy to hear it

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.