Code Monkey home page Code Monkey logo

Comments (3)

isopov avatar isopov commented on May 16, 2024

About the second case:

  1. There is specific comment in the checkstyle source that this exact case should be reported:
    https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheck.java#L89
  2. I use this check to catch files that were not autoformatted. And autoformatter preferences for IDEA at my work (slightly modified defaults) remove this space if it is added.

So should we change the second case at all?

from checkstyle.

romani avatar romani commented on May 16, 2024

Hi @isopov , thanks for investigation, after attentive look at this case :

ListResult<String> result = new ListResult<String>(Collections.<String> emptyList());

I do not think it is good idea to have space at this place. With space it looks like type of some new form of method reference/call.

I am voting for ignoring that request (to have a space after ">") and fix the issue.

from checkstyle.

isopov avatar isopov commented on May 16, 2024

Done.

from checkstyle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.