infra: should use release 11 for compilation about checkstyle HOT 11 CLOSED

Yes, this should be closed, we lost track of it

from checkstyle.

@rnveach you can put the definition of the release property into a profile which is only enabled on JDK9 or higher, see https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html

from checkstyle.

Can you share example of maven config to set this 3 items?

If update is simple, you might be able to make PR from web site editor.

from checkstyle.

Can you share example of maven config to set this 3 items?

@romani ,
Firstly, sorry for getting involved and please do correct me if I am wrong.

Based on my observations from PR #14397 ,
Any other mvn release used other than the current version is raising an API incompatibility error.
I had to find a workaround to keep the version intact and so added a new config to the plugin which did the trick.
I could elaborate a bit more on this if you insist. Please review PR #14397 to see the changes I have made.

from checkstyle.

@romani PR has been made for this issue. I showed it fixes the warning.

from checkstyle.

I can not find such warning at windows builds https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/49208331, strange.

from checkstyle.

@romani See PR, CI only shows at JRE 17

the compiler knows that it's important to also check the API of the Java runtime, because it changes between Java versions.

from checkstyle.

Ok , so it is warming only for java version above 11 ?

from checkstyle.

I can only assume it is for java versions that do not match our POM.

from checkstyle.

@rnveach not sure how you typically process issues, should this one be closed already? the PR is merged, and since that is infrastructure only, there is nothing further to document.

from checkstyle.

9240ad3#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R225
This line fails backport.

[INFO] �[1m--- �[0;32mcompiler:3.12.1:compile�[m �[1m(default-compile)�[m @ �[36mcheckstyle-backport-jre8�[0;1m ---�[m
[INFO] Recompiling the module because of �[1mchanged source code�[m.
[INFO] Compiling 448 source files with javac [debug release 1.8] to target\classes
...
Caused by: java.lang.IllegalArgumentException: invalid flag: --release
	at com.sun.tools.javac.api.JavacTool.processOptions(JavacTool.java:206)
	at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:156)
	at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:107)
	at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:64)
	at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:125)
	... 30 more

This was fixed in JDK 9.
https://bugs.openjdk.org/browse/JDK-8167965

from checkstyle.