HexEditor plugin creates an empty folder "plugins\Compare",about chcg/npp_hexedit

d0vgan commented on August 17, 2024 1

Looks like this folder is used by the function DoCompare where temporary files to be compared are created... I would highly recommend to use e.g. $(PLUGINS_CONFIG_DIR)\HexEdit\Compare or %TEMP%\HexEdit\Compare instead.
The root issue is that a folder Notepad++\plugins\Compare is created by the plugin. This folder is just not applicable for the task of temporary files comparison.

from npp_hexedit.

d0vgan commented on August 17, 2024

The same behavior with HexEditor_0.9.5.19_x86.zip

from npp_hexedit.

chcg commented on August 17, 2024

@d0vgan See

NPP_HexEdit/HexEditor/src/Hex.cpp

Lines 329 to 353 in 4af4aea

    
           ::SendMessage(nppData._nppHandle, NPPM_GETPLUGINSCONFIGDIR, MAX_PATH, (LPARAM)configPath); 
        
           ::PathRemoveBackslash(configPath); 
        
           /* Test if config path exist, if not create */ 
        
           if (::PathFileExists(configPath) == FALSE) 
        
           { 
        
           	vector<string>  vPaths; 
        
           	*_tcsrchr(configPath, '\\') = NULL; 
        
           	do { 
        
           		vPaths.push_back(configPath); 
        
           		*_tcsrchr(configPath, NULL) = NULL; 
        
           	} while (::PathFileExists(configPath) == FALSE); 
        
           	for (size_t i = vPaths.size(); i > 0; --i) 
        
           	{ 
        
           		_tcscpy(configPath, vPaths[i-1].c_str()); 
        
           		::CreateDirectory(configPath, NULL); 
        
           	} 
        
           } 
        
           /* init compare file path */ 
        
           _tcscpy(cmparePath, configPath); 
        
           *_tcsrchr(cmparePath, '\\') = NULL; 
        
           ::PathAppend(cmparePath, COMPARE_PATH);

Seems that is expected behaviour. Since 7.6.x it might make sense to use the plugin subdir to create such a dir.

Additional observation:
The conf dir from NPPM_GETPLUGINSCONFIGDIR is not called first to retrieve the needed buffer size, but called just with MAX_PATH (see https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file, so maybe 260), so if the path exceed that size NULL is provided from N++. This might be the root cause of remaining #1 issues.

from npp_hexedit.

d0vgan commented on August 17, 2024

Ah, I forgot I can build the plugin myself :)
IMHO, this line in "Hex.cpp" just should not be there:
*_tcsrchr(cmparePath, '\\') = NULL;
What it does is it jumps one level up from the "Config" folder.
Why???
I have no answer for this.
I've started to experiment with the code (such as removing the mentioned line). In such case, the "Compare" folder is created under the "Config" folder, but after a few additional actions (when I checked how the comparison works) the plugin just crashed :( That killed my enthusiasm of further experiments.

from npp_hexedit.

HexEditor plugin creates an empty folder "plugins\Compare" about npp_hexedit HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	::SendMessage(nppData._nppHandle, NPPM_GETPLUGINSCONFIGDIR, MAX_PATH, (LPARAM)configPath);
	::PathRemoveBackslash(configPath);

	/* Test if config path exist, if not create */
	if (::PathFileExists(configPath) == FALSE)
	{
	vector<string> vPaths;

	*_tcsrchr(configPath, '\\') = NULL;
	do {
	vPaths.push_back(configPath);
	*_tcsrchr(configPath, NULL) = NULL;
	} while (::PathFileExists(configPath) == FALSE);

	for (size_t i = vPaths.size(); i > 0; --i)
	{
	_tcscpy(configPath, vPaths[i-1].c_str());
	::CreateDirectory(configPath, NULL);
	}
	}

	/* init compare file path */
	_tcscpy(cmparePath, configPath);
	*_tcsrchr(cmparePath, '\\') = NULL;
	::PathAppend(cmparePath, COMPARE_PATH);