Support Rails version 5.1 about sorbet-rails HOT 15 CLOSED

@jasnow can you post your versions of ruby, rails, and activerecord?

Rails and activerecord are both 6.0.0.rc1
Ruby 2.6.3.

from sorbet-rails.

Found answer: 5.2.3

from sorbet-rails.

Yep, Rails 5.2. I've had a plan to change the way we structure rbis to workaround overridden methods. Will implement it soon.

If you just want to have it working, you can:
1/ clone sorbet-rails locally
2/ point to it from the Gemfile
gem 'sorbet-rails', path: "~/sorbet-rails"
and
3/ override
is_method_autogenerated? in model_rbi_formatter#295

from sorbet-rails.

Confirmed that the new version resolves the issue. Thanks for fixing!

from sorbet-rails.

I see this too.

from sorbet-rails.

@jasnow can you post your versions of ruby, rails, and activerecord?

from sorbet-rails.

Will try same repo with Ruby 2.5.5.

from sorbet-rails.

Still getting the "Skip method" messages:

-- Generate sigs for Micropost --
Skip method 'content' because it is not autogenerated by Rails.
Skip method 'content=' because it is not autogenerated by Rails.
Skip method 'created_at' because it is not autogenerated by Rails.
Skip method 'created_at=' because it is not autogenerated by Rails.
Skip method 'updated_at' because it is not autogenerated by Rails.
Skip method 'updated_at=' because it is not autogenerated by Rails.
Skip method 'user_id' because it is not autogenerated by Rails.
Skip method 'user_id=' because it is not autogenerated by Rails.
-- Generate sigs for User --
Skip method 'created_at' because it is not autogenerated by Rails.
Skip method 'created_at=' because it is not autogenerated by Rails.
Skip method 'email' because it is not autogenerated by Rails.
Skip method 'email=' because it is not autogenerated by Rails.
Skip method 'name' because it is not autogenerated by Rails.
Skip method 'name=' because it is not autogenerated by Rails.
Skip method 'updated_at' because it is not autogenerated by Rails.
Skip method 'updated_at=' because it is not autogenerated by Rails.

from sorbet-rails.

It's likely because of different Rails/ActiveRecord version has different class hierarchy.

from sorbet-rails.

What versions of Rails are currently covered?

from sorbet-rails.

FYI I pushed code changes to
1/ refactor generation logic & thus remove the method overridden checks
2/ added tests for Rails 5.1.7
I haven't tested with Rails 6.0.0rc but I think it should work.

@jasnow if you find something broken with 6.0.0rc please let me know. I've also set up structure to test multiple Rails app. If you're interested in making it work for 6.0.0rc I'd love to support too.

from sorbet-rails.

I'm going to close the issue for now because we've addressed the main problem raised. If there is any issue with 6.0.0rc please feel free to file a new one.

from sorbet-rails.

@manhhung741 do you plan to release a new version of the gem today?

from sorbet-rails.

Yes! I'm drafting the release note!

from sorbet-rails.

@willisplummer I deployed v0.2.0 to RubyGems! Thanks for reporting the original issue.

from sorbet-rails.