Code Monkey home page Code Monkey logo

Comments (4)

jaredbeck avatar jaredbeck commented on August 30, 2024

My question is: Should we support jobs with specific arguments, according to my definition of "specific" given above?

If the answer is no, that's fine, but then it seems job files will not be able to have a sigil higher than ignore.

from sorbet-rails.

hdoan741 avatar hdoan741 commented on August 30, 2024

I think if you re-run srb rbi hidden-definitions, it might remove the "non-specific" sig generated by sorbet.
Rerunning hidden-definitions task may be slow :P You can consider removing the sig manually.

Those are sorbet-specific behavior. For sorbet-rails, I think we can generate perform_later and perform_now class methods based on the manually written signature, much like how we generate delivery method for mailers. If you're interested in doing that, I can give you more direction on how to do it. It should be simple because sorbet-rails already has a library method that extracts sorbet signature from a method

from sorbet-rails.

hdoan741 avatar hdoan741 commented on August 30, 2024

Rerunning hidden-definitions task may be slow :P You can consider removing the sig manually.

I mean removing the sig from hidden-definitions.rbi file. It's just an auto-generated file of dynamic methods that sorbet detected in the codebase.

https://sorbet.org/docs/rbi#the-hidden-definition-rbi

from sorbet-rails.

jaredbeck avatar jaredbeck commented on August 30, 2024

I think if you re-run srb rbi hidden-definitions, it might remove the "non-specific" sig generated by sorbet. .. Those are sorbet-specific behavior.

Aha! It does.

So, the lesson is: after I change a sigil from ignore to false (or greater) I should re-run hidden-definitions. That makes sense. When a file is ignored it is not required, thus anything defined in it is "hidden". Thanks, Harry.

I will make a PR to add this tip to the sigil page of the sorbet docs.

For sorbet-rails, I think we can generate perform_later and perform_now class methods based on the manually written signature, much like how we generate delivery method for mailers. .. If you're interested in doing that, I can give you more direction ..

Sure, sounds like fun. I'll open a new issue to discuss.

from sorbet-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.