Comments (4)
My question is: Should we support jobs with specific arguments, according to my definition of "specific" given above?
If the answer is no, that's fine, but then it seems job files will not be able to have a sigil higher than ignore
.
from sorbet-rails.
I think if you re-run srb rbi hidden-definitions
, it might remove the "non-specific" sig generated by sorbet.
Rerunning hidden-definitions
task may be slow :P You can consider removing the sig manually.
Those are sorbet-specific behavior. For sorbet-rails
, I think we can generate perform_later
and perform_now
class methods based on the manually written signature, much like how we generate delivery method for mailers. If you're interested in doing that, I can give you more direction on how to do it. It should be simple because sorbet-rails
already has a library method that extracts sorbet signature from a method
from sorbet-rails.
Rerunning hidden-definitions task may be slow :P You can consider removing the sig manually.
I mean removing the sig from hidden-definitions.rbi
file. It's just an auto-generated file of dynamic methods that sorbet detected in the codebase.
https://sorbet.org/docs/rbi#the-hidden-definition-rbi
from sorbet-rails.
I think if you re-run
srb rbi hidden-definitions
, it might remove the "non-specific" sig generated by sorbet. .. Those are sorbet-specific behavior.
Aha! It does.
So, the lesson is: after I change a sigil from ignore
to false
(or greater) I should re-run hidden-definitions
. That makes sense. When a file is ignore
d it is not required, thus anything defined in it is "hidden". Thanks, Harry.
I will make a PR to add this tip to the sigil page of the sorbet docs.
For sorbet-rails, I think we can generate perform_later and perform_now class methods based on the manually written signature, much like how we generate delivery method for mailers. .. If you're interested in doing that, I can give you more direction ..
Sure, sounds like fun. I'll open a new issue to discuss.
from sorbet-rails.
Related Issues (20)
- Feature: Re-generate model RBIs on db:migrate HOT 2
- Feature: custom methods on associations.
- Signatures not generated for models using new ActiveRecord::DelegatedType
- Has_many with scope on association HOT 2
- Decide whether to drop Ruby 2.4 and Ruby 2.5 HOT 2
- Feature Request: --verify option for CI HOT 1
- FR: helper_generator_class
- Method object does not exist on ActionView::Helpers::FormBuilder HOT 1
- Don't know how to build task 'rails_rbi:routes' HOT 1
- Unable to resolve constant BatchEnumerator HOT 1
- Enum override in ActiveRecordOverrides breaks with Rails 7 HOT 5
- Lots of T.nilable(T.untyped) errors after sorbet 0.5.9556
- Classic Loader issues with srb init HOT 1
- warning: already initialized constant RAILS_RBI_RAKE_DIR
- regression on update to sorbet 0.5.9892+ HOT 1
- `rails_rbi:jobs` raise unknown prefix error HOT 2
- Model with `enum` raises `ArgumentError: wrong number of arguments (given 3, expected 1)`
- Type check errors in generated RBI files HOT 2
- Readme typo custom -> controllers ?
- `pluck_to_tstruct` assigns plucked values to the wrong tstruct keys depending on the order in which the tstruct props for associations are listed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sorbet-rails.