Comments (5)
If so, happy to submit a PR!
Yes please!
from sorbet-rails.
Just curious - is this something we still want to resolve? It seems like ActiveSupport::HashWithIndifferentAccess
now exists in sorbet-typed
.
If so, happy to submit a PR!
from sorbet-rails.
This is my first time contributing to sorbet-rails
, so forgive me for my lack of experience; I have a few questions!
My understanding is that to change the enum values for a model, I should look to change the types in active_record_enum.rb
. Is that correct?
And to add - looking at the class def for ActiveSupport::HashWithIndifferentAccess
, it subclasses their Hash
type, which I'm not sure if it's a template type. Am I understanding how to use this properly?
i.e., should my new code look like this?
return_type = if value_type.length == 1
"ActiveSupport::HashWithIndifferentAccess[#{value_type.first}]" # should this template type be here?
else
"ActiveSupport::HashWithIndifferentAccess[T.any(#{value_type.join(', ')})]" # should this template type be here?
end
Or this; but, I feel like I'm losing some type information?
return_type = "ActiveSupport::HashWithIndifferentAccess"
from sorbet-rails.
Hmm, this works fine, but as you say it loses type information.
But this does not.
@jeffcarbs you added the ActiveSupport::HashWithIndifferentAccess
sig here but do you mind sharing how it's typically used?
from sorbet-rails.
While we wait for @jeffcarbs' answer, I'll note that the documentation for the class has examples where values are of different types:
rgb = ActiveSupport::HashWithIndifferentAccess.new
rgb[:black] = '#000000'
hash = ActiveSupport::HashWithIndifferentAccess.new(a: 1)
So I'm sure that there are typical uses where the values are different types.
This seems suitable for a generic type to me, which may make upgrading for users easier since it then just becomes a find-and-replace for T::Hash[T.any(String, Symbol),
-> ActiveSupport::HashWithIndifferentAccess[
. In that case, we also won't lose type information!
However, I'm not sure if this is bad practice since we're modifying how ActiveSupport::HashWithIndifferentAccess
is defined internally, and that sounds like a breaking change to me. It also seems like generics are still an experimental feature in sorbet. My understanding is that we would lose generic types (type erasure?). It may be difficult to implement (though I'd still like to try if possible!).
Any thoughts @ghiculescu? I'm coming with little experience with sorbet or rails (my background is not in ruby) so any thoughts are appreciated!
from sorbet-rails.
Related Issues (20)
- Feature: Re-generate model RBIs on db:migrate HOT 2
- Feature: custom methods on associations.
- Signatures not generated for models using new ActiveRecord::DelegatedType
- Has_many with scope on association HOT 2
- Decide whether to drop Ruby 2.4 and Ruby 2.5 HOT 2
- Feature Request: --verify option for CI HOT 1
- FR: helper_generator_class
- Method object does not exist on ActionView::Helpers::FormBuilder HOT 1
- Don't know how to build task 'rails_rbi:routes' HOT 1
- Unable to resolve constant BatchEnumerator HOT 1
- Enum override in ActiveRecordOverrides breaks with Rails 7 HOT 5
- Lots of T.nilable(T.untyped) errors after sorbet 0.5.9556
- Classic Loader issues with srb init HOT 1
- warning: already initialized constant RAILS_RBI_RAKE_DIR
- regression on update to sorbet 0.5.9892+ HOT 1
- `rails_rbi:jobs` raise unknown prefix error HOT 2
- Model with `enum` raises `ArgumentError: wrong number of arguments (given 3, expected 1)`
- Type check errors in generated RBI files HOT 2
- Readme typo custom -> controllers ?
- `pluck_to_tstruct` assigns plucked values to the wrong tstruct keys depending on the order in which the tstruct props for associations are listed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sorbet-rails.