Comments (12)
hdoan741
commented on July 26, 2024
1
The documentation change is merged
from sorbet-rails.
hdoan741
commented on July 26, 2024
Can I ask if sorbet-rails is included in your test and production
environment? Those classes are Rails private class. We have logic that is
loaded through initializer to make them publicly accessible. Usually this
error you see means they aren't publicly available.
…On Tue, Oct 22, 2019 at 3:50 AM Fran Casas ***@***.***> wrote:
*Describe the bug:*
When you declare a method which receives or returns an
ActiveRecord_AssociationRelation of some sort, tests fail with:
NameError:
private constant #<Class:0x00007fa75c4e8d28>::ActiveRecord_AssociationRelation referenced
*Steps to reproduce:*
create a method which returns an association relation on a model
class Post < ApplicationRecord
belongs_to :user
scope :published ->() { where(published: true) }end
class User < ApplicationRecord
extend T::Sig
has_many :posts
sig { returns(Post::ActiveRecord_AssociationRelation) }
def published_posts
posts.published
endend
RSpec.describe User do
describe '#published_posts' do
it 'returns only the published posts' do
user = User.create!
published = user.posts.create(published: true)
user.posts.create(published: false)
expect(user.published_posts).to eq([published])
end
endend
This would raise a NameError claming that
Post::ActiveRecord_AssociationRelation is a private class.
Note as well that in my case the models are on a rails engine.
*Expected behavior:*
The test passes
*Versions:*
- Ruby: 2.4
- Rails: 5.2.3
- Sorbet: Sorbet typechecker 0.4.4891 git
4c9a4534439483b46e869c7212007ad103923203 built on 2019-10-17 22:56:24 GMT
debug_symbols=true
- Sorbet-Rails: 0.5.8
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#211?email_source=notifications&email_token=AAFH4AP3IUSHDKALA2KOY53QP3LGFA5CNFSM4JDN4QB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTOYF4Q>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFH4AJDINQJMAV3YWACGS3QP3LGFANCNFSM4JDN4QBQ>
.
from sorbet-rails.
franciscoj
commented on July 26, 2024
You're totally right.
I think I've managed to fix it by moving gem 'sorbet-rails' on the Gemfile from the group :development block to the general group.
Thanks a lot!
from sorbet-rails.
International
commented on July 26, 2024
I have sorbet-rails in the general group, but I receive the same issue with private constant being referenced.
EDIT: I notice that in development mode, the inherited hook does not fire, while in production mode it does. Guessing it's because of eager_load?
from sorbet-rails.
franciscoj
commented on July 26, 2024
I can confirm that moving it to the general group fixed the issue for me. Besides the code is now running on CI and on production with some MyModel::ActiveRecord_Association typed methods.
@International what I did to see what was happening on my case was to:
bundle open sorbet-rails
Go to the railties file and add a byebug on the inherited hook.
Then starting the rails console on development (where it worked) and on test, where it didn't. That way I realised what the issue was.
Not sure it can help you debug your case... but you never know!
Guessing it's because of eager_load
I doubt that could be the case, take into account that these patches sorbet-rails do are hooked to certaing loading events which are fired when things like ActiveRecord::Base load. It would mean that your app isn't loading those, which would be really weird.
If you wanted to confirm you could add an initializer in the same fashion as sorbet-rails does and check if it gets called or not.
from sorbet-rails.
International
commented on July 26, 2024
Hi @franciscoj , thanks for the tip, I did that :)
On one side, what I noticed is that the hook only gets called for about 10 out of 200 models, in development mode, on the other it looks like the railtie should probably be required kind of early so that models coming from gems would also get the hook?
I noticed that also for models defined in gems, the constant is private.
from sorbet-rails.
franciscoj
commented on July 26, 2024
I noticed that also for models defined in gems, the constant is private.
AFAIK for models coming from gems you need to use plugins, like the ones described here https://github.com/chanzuckerberg/sorbet-rails#enabling-built-in-plugins
But I'm afraid I don't know how to add new ones or create your own plugins.
from sorbet-rails.
International
commented on July 26, 2024
I will try to play around with load order, see if I can force it to get it loaded. Let you know what I find. Thanks
from sorbet-rails.
hdoan741
commented on July 26, 2024
Hi George,
I’m sorry to hear you run into this issue. Can you describe your set up and
sorbet-rails version?
- Rails version
- sorbet version
- sorbet-rails version
- gem affected
There was an old version of sorbet-rails that we did it in an unreliable
way. The latest version was supposed to fix it (it overrides “inherited” so
any model will have the code run). Can you try upgrading sorbet-rails to
see if it works?
If you can set up a repro case, it’ll be very useful for my debugging.
…On Wed, Oct 23, 2019 at 8:17 AM Fran Casas ***@***.***> wrote:
I noticed that also for models defined in gems, the constant is private.
AFAIK for models coming from gems you need to use plugins, like the ones
described here
https://github.com/chanzuckerberg/sorbet-rails#enabling-built-in-plugins
But I'm afraid I don't know how to add new ones or create your own plugins.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#211?email_source=notifications&email_token=AAFH4APMKCIQ6FL3YTCWPB3QQBTJDA5CNFSM4JDN4QB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECBZNTA#issuecomment-545494732>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFH4ANJ47VEDDURFQNNUPDQQBTJDANCNFSM4JDN4QBQ>
.
from sorbet-rails.
hdoan741
commented on July 26, 2024
Just to clarify, this is a separate issue from the custom plugin for the
rbi generation logic. (For that process we should pick up all models,
including models from plugin — hopefully, I haven't had problem with that)
This process is a run-time set up to help with run-time checks and
shouldn’t require writing any gem plugins.
Maybe I should try to clarify the differences between the two in README.
Currently the run-time component of sorbet-rails is not well
documented/separated.
…On Wed, Oct 23, 2019 at 8:17 AM Fran Casas ***@***.***> wrote:
I noticed that also for models defined in gems, the constant is private.
AFAIK for models coming from gems you need to use plugins, like the ones
described here
https://github.com/chanzuckerberg/sorbet-rails#enabling-built-in-plugins
But I'm afraid I don't know how to add new ones or create your own plugins.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#211?email_source=notifications&email_token=AAFH4APMKCIQ6FL3YTCWPB3QQBTJDA5CNFSM4JDN4QB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECBZNTA#issuecomment-545494732>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFH4ANJ47VEDDURFQNNUPDQQBTJDANCNFSM4JDN4QBQ>
.
from sorbet-rails.
hdoan741
commented on July 26, 2024
@International also I think likely the load order shouldn’t be a problem
(in the newest version).
…On Wed, Oct 23, 2019 at 8:31 AM Harry Doan ***@***.***> wrote:
Just to clarify, this is a separate issue from the custom plugin for the
rbi generation logic. (For that process we should pick up all models,
including models from plugin — hopefully, I haven't had problem with that)
This process is a run-time set up to help with run-time checks and
shouldn’t require writing any gem plugins.
Maybe I should try to clarify the differences between the two in README.
Currently the run-time component of sorbet-rails is not well
documented/separated.
On Wed, Oct 23, 2019 at 8:17 AM Fran Casas ***@***.***>
wrote:
> I noticed that also for models defined in gems, the constant is private.
> AFAIK for models coming from gems you need to use plugins, like the ones
> described here
> https://github.com/chanzuckerberg/sorbet-rails#enabling-built-in-plugins
>
> But I'm afraid I don't know how to add new ones or create your own
> plugins.
>
> —
> You are receiving this because you commented.
>
>
> Reply to this email directly, view it on GitHub
> <#211?email_source=notifications&email_token=AAFH4APMKCIQ6FL3YTCWPB3QQBTJDA5CNFSM4JDN4QB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECBZNTA#issuecomment-545494732>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAFH4ANJ47VEDDURFQNNUPDQQBTJDANCNFSM4JDN4QBQ>
> .
>
from sorbet-rails.
hdoan741
commented on July 26, 2024
FYI there is a PR to improve the documentation around this #214
from sorbet-rails.
Related Issues (20)
- Feature: Re-generate model RBIs on db:migrate HOT 2
- Feature: custom methods on associations.
- Signatures not generated for models using new ActiveRecord::DelegatedType
- Has_many with scope on association HOT 2
- Decide whether to drop Ruby 2.4 and Ruby 2.5 HOT 2
- Feature Request: --verify option for CI HOT 1
- FR: helper_generator_class
- Method object does not exist on ActionView::Helpers::FormBuilder HOT 1
- Don't know how to build task 'rails_rbi:routes' HOT 1
- Unable to resolve constant BatchEnumerator HOT 1
- Enum override in ActiveRecordOverrides breaks with Rails 7 HOT 5
- Lots of T.nilable(T.untyped) errors after sorbet 0.5.9556
- Classic Loader issues with srb init HOT 1
- warning: already initialized constant RAILS_RBI_RAKE_DIR
- regression on update to sorbet 0.5.9892+ HOT 1
- `rails_rbi:jobs` raise unknown prefix error HOT 2
- Model with `enum` raises `ArgumentError: wrong number of arguments (given 3, expected 1)`
- Type check errors in generated RBI files HOT 2
- Readme typo custom -> controllers ?
- `pluck_to_tstruct` assigns plucked values to the wrong tstruct keys depending on the order in which the tstruct props for associations are listed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sorbet-rails.