Code Monkey home page Code Monkey logo

Comments (13)

hdoan741 avatar hdoan741 commented on September 26, 2024

Thanks for flagging. Does this problem occur when you don't run sorbet-rails?

from sorbet-rails.

hdoan741 avatar hdoan741 commented on September 26, 2024

To see "srb tc" errors, just change "ignore" to "false" and run "srb tc". Thanks.

Can you also provide a paste when you change all the ignore files to false and run srb tc?

from sorbet-rails.

jasnow avatar jasnow commented on September 26, 2024

Thanks for flagging. Does this problem occur when you don't run sorbet-rails?

Using above repo:

With sorbet-rails:
2 # typed: autogenerated
12 # typed: false
33 # typed: ignore
38 # typed: strong
11 # typed: true
96 TOTAL

Without sorbet-rails:
2 # typed: autogenerated
5 # typed: false
6 # typed: ignore
9 # typed: strict
47 # typed: strong
19 # typed: true
88 TOTAL

from sorbet-rails.

jasnow avatar jasnow commented on September 26, 2024

To see "srb tc" errors, just change "ignore" to "false" and run "srb tc". Thanks. Can you
also provide a paste when you change all the ignore files to false and run srb tc?

https://gist.github.com/jasnow/6b0e0a63a70af660f9aaecdfdc63471e

from sorbet-rails.

hdoan741 avatar hdoan741 commented on September 26, 2024

It looks like an issue with sorbet-typed -- 6 rails files were ignored before sorbet-rails added.
I've found them really difficult to resolve manually. Instead, reinitializing srb will make them go away

1- delete sorbet/ folder
2- run srb init
3- check ignored files
4- add sorbet-rails

Please let me know if this resolve your issue.

from sorbet-rails.

jasnow avatar jasnow commented on September 26, 2024

Where have we documented the problem of method definition in BOTH sorbet-typed and sorbet/rbi/gems ? This example covered "activemodel" methods.

from sorbet-rails.

hdoan741 avatar hdoan741 commented on September 26, 2024

from sorbet-rails.

jasnow avatar jasnow commented on September 26, 2024

Added question to Slack/Sorbet/Discuss channel.

from sorbet-rails.

jasnow avatar jasnow commented on September 26, 2024

Found a workaround. Removed 'srb rbi suggest-typed' from my daily script.
Now "srb tc" down to 1 error so I will work that separately.

sorbet/rbi/todo.rbi:1x: `ActiveStorage::Attachment` was 
previously defined as a `class` https://srb.help/4012
    1x |module ActiveStorage::Attachment; end
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

from sorbet-rails.

hdoan741 avatar hdoan741 commented on September 26, 2024

from sorbet-rails.

jasnow avatar jasnow commented on September 26, 2024

When you say "running sorbet-rails", you mean "rake rails_rbi:all"

from sorbet-rails.

hdoan741 avatar hdoan741 commented on September 26, 2024

from sorbet-rails.

jasnow avatar jasnow commented on September 26, 2024

Now I can re-add "srb rbi suggest-typed" and moved all rails_rbi command to the end.
Still have one "srb tc" error in todo.rbi file.

from sorbet-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.