Comments (5)
hdoan741
commented on August 30, 2024
@connorshea do you know what can be wrong here? Maybe because there is no Helper?
from sorbet-rails.
connorshea
commented on August 30, 2024
oh, hm yeah that'll do it.
We could probably fix it by changing this line to use helpers&.length == 0 || helpers.nil? or helpers.nil? || helpers.length == 0, though that might just cause an error to occur further along in the code instead.
from sorbet-rails.
hdoan741
commented on August 30, 2024
We should do nothing if there is no helpers.
…On Tue, Aug 13, 2019 at 6:19 PM Connor Shea ***@***.***> wrote:
oh, hm yeah that'll do it.
We could probably fix it by changing this line to use helpers&.length ==
0 || helpers.nil? or helpers.nil? || helpers.length == 0, though that
might just cause an error to occur further along in the code instead.
https://github.com/chanzuckerberg/sorbet-rails/blob/6c600c0256084e76694475a3f3fdfc5c9e1b5dbe/lib/sorbet-rails/tasks/rails_rbi.rake#L53
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#120?email_source=notifications&email_token=AAFH4APIIG76JNII2TDUKD3QENMR7A5CNFSM4ILDQYB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HNODI#issuecomment-521066253>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFH4APT23PUW3D5ORICOV3QENMR7ANCNFSM4ILDQYBQ>
.
from sorbet-rails.
connorshea
commented on August 30, 2024
That's specifically checking if the previous attempt to get the helpers returned anything, so it's supposed to check that there aren't any.
from sorbet-rails.
hdoan741
commented on August 30, 2024
Ah the check on L53 is inverted. It should check helpers.nil? first then
check the length.
I think after that, and before we call the generator, we should check again
that helpers is defined before proceeding.
…On Tue, Aug 13, 2019 at 6:33 PM Connor Shea ***@***.***> wrote:
That's specifically checking if the previous attempt to get the helpers
returned anything, so it's supposed to check that there aren't any.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#120?email_source=notifications&email_token=AAFH4AOCCXGH6OBIS5XPBGTQENOGTA5CNFSM4ILDQYB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HOBWA#issuecomment-521068760>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFH4AKBQMQT5FAXNMI4TNLQENOGTANCNFSM4ILDQYBQ>
.
from sorbet-rails.
Related Issues (20)
- Feature: Re-generate model RBIs on db:migrate HOT 2
- Feature: custom methods on associations.
- Signatures not generated for models using new ActiveRecord::DelegatedType
- Has_many with scope on association HOT 2
- Decide whether to drop Ruby 2.4 and Ruby 2.5 HOT 2
- Feature Request: --verify option for CI HOT 1
- FR: helper_generator_class
- Method object does not exist on ActionView::Helpers::FormBuilder HOT 1
- Don't know how to build task 'rails_rbi:routes' HOT 1
- Unable to resolve constant BatchEnumerator HOT 1
- Enum override in ActiveRecordOverrides breaks with Rails 7 HOT 5
- Lots of T.nilable(T.untyped) errors after sorbet 0.5.9556
- Classic Loader issues with srb init HOT 1
- warning: already initialized constant RAILS_RBI_RAKE_DIR
- regression on update to sorbet 0.5.9892+ HOT 1
- `rails_rbi:jobs` raise unknown prefix error HOT 2
- Model with `enum` raises `ArgumentError: wrong number of arguments (given 3, expected 1)`
- Type check errors in generated RBI files HOT 2
- Readme typo custom -> controllers ?
- `pluck_to_tstruct` assigns plucked values to the wrong tstruct keys depending on the order in which the tstruct props for associations are listed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sorbet-rails.