Code Monkey home page Code Monkey logo

Comments (2)

mrjohannchang avatar mrjohannchang commented on July 20, 2024

Hi @JPHutchins, yes of course! And it will be a huge improve! I should move this repo to an org then.

from aioserial.py.

JPHutchins avatar JPHutchins commented on July 20, 2024

@changyuheng Awesome! Work got a tad busy, but I've signed up for the python async and pywin32 mailing lists, each of which I need to submit some best practices questions to.

If you're curious, here is the quick modification of the Serial class to make it async: https://github.com/JPHutchins/pyserial/pull/1/files

It works, but the way that I listen for OS events:

        self._read_future = self._loop._proactor.wait_for_handle(self._overlapped_read.hEvent)
        self._write_future = self._loop._proactor.wait_for_handle(self._overlapped_write.hEvent)

seems questionable so I hope that the python async mailing list can fill me in on best practices.

We'd have to decide on how to bring these changes in... probably just subclassing Serial and adding the async stuff would be simplest.

I'll be in touch after I learn more.

Cheers,
J.P.

from aioserial.py.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.