Code Monkey home page Code Monkey logo

Comments (4)

codebender828 avatar codebender828 commented on May 21, 2024 1

Hey @peoray ! Sorry for my late response. I haven't looked at this thread since yesterday.

Just looked at the file. Yes, you're right. we can use the _inputId variable It can be fixed by removing the default property on the inputId prop. That's what's causing the id duplication.

from chakra-ui-vue.

peoray avatar peoray commented on May 21, 2024

Picking this up if it's still up.

So I'm a little bit confused.id generation is done by the useId function in utils. Either that or as a inputId prop passed by the user. What exactly do you mean by moving id generation to computed property?

@codebender828

from chakra-ui-vue.

codebender828 avatar codebender828 commented on May 21, 2024

Hey @peoray . Thanks for taking this up.

Currently there's an id prop that has a default.

The problem is that since this function is called at build time, and not at component instantiation time, this can result in the same value each time time the the component is used in the template.

To solve this we need to move that function call to the computer property. You can see this in the RadioGroup component.

return this.name || `radio-${useId()}`

from chakra-ui-vue.

peoray avatar peoray commented on May 21, 2024

Might probably sound silly but isn't the _inputId already a computed property or is there something I'm missing?

from chakra-ui-vue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.