Code Monkey home page Code Monkey logo

Comments (2)

Hachikoi-the-creator avatar Hachikoi-the-creator commented on September 4, 2024

nvm I broke it

from giftlist.

Hachikoi-the-creator avatar Hachikoi-the-creator commented on September 4, 2024

Found a what I think could be a logic bug tho.

function verifyProof(proof, leaf, root) {
  proof = proof.map(({ data, left }) => ({
    left,
    data: hexToBytes(data),
  }));
  let data = keccak256(Buffer.from(leaf));

  for (let i = 0; i < proof.length; i++) {
    if (proof[i].left) {
      data = concat(proof[i].data, data);
    } else {
      data = concat(data, proof[i].data);
    }
  }

  return bytesToHex(data) === root;
}

since verify proof will be used in the serve and we cannot transfer uint8Arrays tru http, I modified it so the inputs use strings (hex) and in the concat we do the hextToBytes

import { keccak256 } from "ethereum-cryptography/keccak";
import { bytesToHex, hexToBytes } from "ethereum-cryptography/utils";
import { ProofVer } from "./merkleTree";

const concat = (left: Uint8Array, right: Uint8Array) =>
  keccak256(Buffer.concat([left, right]));

export function verifyProof(proof: ProofVer[], leaf: string, root: string) {
  let data: Uint8Array = keccak256(Buffer.from(leaf));

  for (let i = 0; i < proof.length; i++) {
    if (proof[i].left) {
      data = concat(hexToBytes(proof[i].data), data);
    } else {
      data = concat(data, hexToBytes(proof[i].data));
    }
  }

  return bytesToHex(data) === root;
}

that is the ts version where I was able to spot the error

Adding extra type for context

export type ProofVer = {
  left: boolean;
  data: string;
};

from giftlist.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.