Comments (9)
Thanks @Jandev, wasn't sure of the current state of the ARM templates. Will add them there.
from cfpexchange.
Boom!
from cfpexchange.
I'll pick this one up.
from cfpexchange.
Hi, quick question! I'm working on this issue, and I encountered the DownloadEventImageMessageSender
class that sends the message for downloading event images.
It contains this code:
var queueClient = new QueueClient(
new ServiceBusConnectionStringBuilder(servicebusConnectionstring),
ReceiveMode.ReceiveAndDelete);
[...]
await queueClient.SendAsync(message);
I'm curious why the ReceiveMode
is explicitly set, while it's an optional parameter and we're just sending messages here.
Long story short: should it stay or should it go?
EDIT:
I think it's done. I didn't specify the ReceiveMode
for sending the Twitter service bus message. There's a setting that needs to be added to the website, and several (the Twitter ones) to the Function App. Can I create a PR so you can take care of that part? It's easier with access to the Azure subscription 🤓
from cfpexchange.
I think the ReceiveMode
isn't necessary indeed, it doesn't make sense over here.
There's a setting that needs to be added to the website and several (the Twitter ones) to the Function App
A setting you can't set in ARM?
In the past, I've pinged @jfversluis in my PR with a step-by-step plan to set settings like that.
from cfpexchange.
Can I create a PR so you can take care of that part? It's easier with access to the Azure subscription 🤓
Can I add people to just a part already in Azure? In that case I'll be happy to set something up if that makes your life easier ;)
What else do you need from me at this point?
from cfpexchange.
Can I add people to just a part already in Azure?
Yes, you can! I'll try to add the settings to the ARM template though. Shouldn't be an issue.
from cfpexchange.
One setting added, moved some around. Should be OK.
Side note: I now reference a secret in Key Vault (as is the case with a similar setting) which isn't in there and doesn't look like it's added through ARM. So please take that into account 😄.
The PR is live: #109 .
from cfpexchange.
Since PR #109 has been merged, it looks like this issue can be closed. 🤓
from cfpexchange.
Related Issues (20)
- Add a list of known conferences
- Event image scaling/sizing
- Add "under conditions" or similar to expenses options
- Use Dependency Injection in Functions HOT 2
- Submit a Sessionize CFP HOT 2
- Rearchitect the application to API-first HOT 6
- Move EF stuff into its own project
- Move CfpService into Common.Services HOT 3
- Themes folder 📁 HOT 1
- Tweets not being sent on new CFP HOT 7
- Error handling in new CFP submission HOT 1
- Add YAML build to sourcecontrol HOT 9
- Make App Insights work for the main application HOT 1
- Where are all the tests? HOT 4
- Azure Function to download images locally misbehaves HOT 8
- Set an event as your favorite HOT 1
- Implement user accounts
- Add develop branch to mature development process HOT 12
- Add (Google) Analytics to see how users use the website HOT 5
- Add support for virtual events HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cfpexchange.