Code Monkey home page Code Monkey logo

Comments (9)

rickvdbosch avatar rickvdbosch commented on May 26, 2024 1

Thanks @Jandev, wasn't sure of the current state of the ARM templates. Will add them there.

from cfpexchange.

jfversluis avatar jfversluis commented on May 26, 2024 1

Boom!

from cfpexchange.

rickvdbosch avatar rickvdbosch commented on May 26, 2024

I'll pick this one up.

from cfpexchange.

rickvdbosch avatar rickvdbosch commented on May 26, 2024

Hi, quick question! I'm working on this issue, and I encountered the DownloadEventImageMessageSender class that sends the message for downloading event images.

It contains this code:

var queueClient = new QueueClient(
    new ServiceBusConnectionStringBuilder(servicebusConnectionstring),
    ReceiveMode.ReceiveAndDelete);

[...]

await queueClient.SendAsync(message);

I'm curious why the ReceiveMode is explicitly set, while it's an optional parameter and we're just sending messages here.

Long story short: should it stay or should it go?

EDIT:
I think it's done. I didn't specify the ReceiveMode for sending the Twitter service bus message. There's a setting that needs to be added to the website, and several (the Twitter ones) to the Function App. Can I create a PR so you can take care of that part? It's easier with access to the Azure subscription 🤓

from cfpexchange.

Jandev avatar Jandev commented on May 26, 2024

I think the ReceiveMode isn't necessary indeed, it doesn't make sense over here.

There's a setting that needs to be added to the website and several (the Twitter ones) to the Function App

A setting you can't set in ARM?
In the past, I've pinged @jfversluis in my PR with a step-by-step plan to set settings like that.

from cfpexchange.

jfversluis avatar jfversluis commented on May 26, 2024

Can I create a PR so you can take care of that part? It's easier with access to the Azure subscription 🤓

Can I add people to just a part already in Azure? In that case I'll be happy to set something up if that makes your life easier ;)

What else do you need from me at this point?

from cfpexchange.

rickvdbosch avatar rickvdbosch commented on May 26, 2024

Can I add people to just a part already in Azure?

Yes, you can! I'll try to add the settings to the ARM template though. Shouldn't be an issue.

from cfpexchange.

rickvdbosch avatar rickvdbosch commented on May 26, 2024

One setting added, moved some around. Should be OK.
Side note: I now reference a secret in Key Vault (as is the case with a similar setting) which isn't in there and doesn't look like it's added through ARM. So please take that into account 😄.
The PR is live: #109 .

from cfpexchange.

rickvdbosch avatar rickvdbosch commented on May 26, 2024

Since PR #109 has been merged, it looks like this issue can be closed. 🤓

from cfpexchange.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.