Mixed content on site due to loading external images about cfpexchange HOT 14 CLOSED

Yeah, I'll get on it asap.
Last week was a bit hectic due to being sick, but all better now :-)

from cfpexchange.

I'd put the scaling and sizing in a different PR, just to keep stuff clean.

Otherwise I'll have to rename my feature toggle also ;-)

from cfpexchange.

Yeah I noticed too. Together with images being shown weird to fit them in our layout. So downloading and serve them ourselves might not be bad together with resizing it to whatever we need

from cfpexchange.

I'd propose doing it something like this.
First, let the user Submit their CFP. In this POST we can place a message on an Azure Servicebus Queue. This message should probably look something like this:

{
    "id": "guid",
    "eventImageUrl": "string"
}

An Azure Function will automatically be triggered by this message on the queue.
This Function will download the image from the eventImageUrl and store it in some (public) storage container (via an output binding to this storage container).

Of course, this Function will also have to update the EventImage in the repository. That's why we're sending the id in the message, so it can update this record in the repository.

Easy, eh...? :-)

Maybe it's a good idea to create a small ARM-template first before adding all of these dependencies.

from cfpexchange.

That sounds amazing!

from cfpexchange.

That being said, I'd love to take a look at this, but I could use some help with it. Maybe we can join forces?

from cfpexchange.

Great news! No worries, I didn't want to rush you! Was just wondering if you put the idea out there or also was going to do some work on it :)

from cfpexchange.

An update on the matter.

Just finished sending a message to the servicebus queue.
Now ready to create an Azure Function which will pick up the message, download the image, store it on one of our local storage accounts and update the record in the database with the new image url.
This second part should be easy :-)

from cfpexchange.

Awesome! I'm not really an image/design expert. But do we need to resize them all to the same size for consistency and good looks etc.? Or is that in there as well? Or maybe one step at a time... 😉

from cfpexchange.

So, App Insights in place, own image downloading should work, but doesn't. Any ideas? Any ideas on how to detect what is wrong?

Setting in production looks like this:

The code is just like on the master branch right now

from cfpexchange.

If Application Insights is set up correctly, you should be able to see something like this.

The calls, failures, stacktrace, etc.
Might be useful for investigation.

Also, have you added the Application Insights setting to the Function App, or not yet?

from cfpexchange.

That I see! But nothing that seems related to the not downloading of images...

And I don't think Insights is setup for the Function yet. Let's see if I can get that to work.

from cfpexchange.

App Insights in Function is enabled and added #103 to deploy this automagically.

Tried it out with this CPF: https://cfp.exchange/cfp/details/euruko19-june-21st-22nd-2019-rotterdam
And it suddenly seems to work... Let's see if it stays that way.

from cfpexchange.

It seems downloading to our own blob storage works for now. Closing this one, if something comes up we'll open a new issue for that.

from cfpexchange.