Code Monkey home page Code Monkey logo

Comments (3)

patrickgalbraith avatar patrickgalbraith commented on August 20, 2024

Ok I fixed the issue myself but it requires a patch to content.js. Basically just added an event listener for DOMNodeInserted.

Change on line 262

        $(theRule.ajaxInitiatorSelector).live("click", function (e) {
            allComments.each(function (idx, el) {
                el.addEventListener("DOMNodeRemoved", refilterComments, false);
                el.addEventListener("DOMNodeInserted", refilterComments, false);
            });
        });

Change on line 280:

function doRefilterComments() {
    $(theRule.allCommentsSelector).each(function (idx, el) {
        el.removeEventListener("DOMNodeRemoved", refilterComments, false);
        el.removeEventListener("DOMNodeInserted", refilterComments, false);
    });

    filterComments(true);
}

And the updated filter:

{
   "id":"gomtvnet@hamradio",
   "label":"GomTV.net",
   "url":"^http://www.gomtv\\.net/.*$",
   "allCommentsSelector":"#reply",
   "commentContainerSelector":"#gomChat li",
   "commentTextSelector":".status-body",
   "commentHideSelector":"> *",
   "statusPlacement":"before",
   "statusElementTag":"div",
   "statusElementAttributes":{
      "class":"status-content"
   },
   "ajaxInitiatorSelector":".commnet_off, .commnet_on, .expand_list",
   "dynamic":true
}

Seems to be working really well with that patch.

from comment-snob.

cfinke avatar cfinke commented on August 20, 2024

Wow, GitHub didn't email me your follow-up comment, and I ended up implementing the exact same patch in version 6, which I just published on the Chrome Web Store. Thanks for the report.

from comment-snob.

patrickgalbraith avatar patrickgalbraith commented on August 20, 2024

Great that you got the fix out thanks for that. Awesome extension by the way, lot of fun to play around with especially the keyword filtering.

from comment-snob.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.