Offset Scroll Location about smooth-scroll HOT 8 CLOSED

https://github.com/cferdinandi/smooth-scroll#fixed-headers

from smooth-scroll.

Ahh... don't know how I missed that :/ Thanks!

from smooth-scroll.

no worries. Happy to help!

from smooth-scroll.

Would it be possible to define this by hand instead of automatically getting the height? I think it would be much more useful as many times you might want to manually adjust the offset to leave more white space or something like that.

Also, the problem with the current implementation is that it calculates the wrong height under certain circumstances, so I had to change the code so that I could manually enter the pixel amount I want: https://github.com/adtile/fixed-nav/blob/master/js/scroll.js#L127 (here's the live demo: http://www.adtile.me/fixed-nav/)

So my question is, should this actually be an option in smoothScroll so that you could manually define it? Think it would be more helpful than the current implementation. Just a fast example below on what I mean:

smoothScroll.init({
    speed: 500, // How fast to complete the scroll in milliseconds
    easing: 'easeInOutCubic', // Easing pattern to use
    offsetMargin: 302, // Negative or positive margin that is added or removed from the offset scroll location
    updateURL: false, // Boolean. Whether or not to update the URL with the anchor hash on scroll
    callbackBefore: function ( toggle, anchor ) {}, // Function to run before scrolling
    callbackAfter: function ( toggle, anchor ) {} // Function to run after scrolling
});

This way, if it was part of the options object, you would also be able to manually change it between different media query breakpoints if needed.

I could also implement this/do a pull if you think this is something we could consider adding. :-)

from smooth-scroll.

Hi @Cam - I plan on adding an offset option, but that will only add additional padding to the auto-measurement it takes. If you'd prefer to enter it on your own, the solution today would be to manually call the animateScroll function in your own script. https://github.com/cferdinandi/smooth-scroll#use-smooth-scroll-events-in-your-own-scripts

from smooth-scroll.

@viljamis - I just pushed version 4.5, which adds offset as an option both in the init call and as a link-by-link override. Cheers!

from smooth-scroll.

@cferdinandi Awesome, I’ll check out the new version! :-)

from smooth-scroll.

You can still automatically get the height if you want, and use the offset to add additional padding.

from smooth-scroll.