Code Monkey home page Code Monkey logo

Comments (7)

cgwalters avatar cgwalters commented on July 26, 2024 1

#397 will help, but won't be on by default.

My inclination then is to close this by documenting the usage of a simple systemd unit that executes growpart on the root.

from centos-bootc.

cgwalters avatar cgwalters commented on July 26, 2024

Someone also floated the idea that we use LVM by default; if we do that it'd change things here; in some ways it'd be simpler. (There's also stratis, etc.)

from centos-bootc.

jlebon avatar jlebon commented on July 26, 2024

One thing is growpart doesn't grow the filesystem. Hmm, if we really wanted, we could probably lift ignition-ostree-growfs.sh out of f-c-c, clean it up, and share it somehow. Though it's begging to be rewritten in a proper language (if we do that, we could propose adding it to cloud-utils directly).

from centos-bootc.

cgwalters avatar cgwalters commented on July 26, 2024

There's a big difference here which is that code is designed to run in the initramfs, whereas traditionally cloud-init's growpart runs in the real root (though I bet it could run from the initramfs). And this gets into the fact that we don't ship the filesystem tools in the initramfs in this base image because it's designed to either be installed "dynamically" (e.g. bootc install/anaconda that make filesystems on the target system), or bib but that should be tuning the filesystem choices again based on input osbuild/bootc-image-builder#52

The rootfs growing is really for generic cloud images, and so...the more I think about it, the root problem here is really what bib is doing linked from that above issue.

Adding growpart just gives us that baseline tool as an out for a broken situation.

(Anyone can feel free to reopen if you disagree of course)

from centos-bootc.

cgwalters avatar cgwalters commented on July 26, 2024

We went back and forth on this and decided for now to try to add growpart to the base, but that dropped off the radar. It's...just very messy.

from centos-bootc.

fabiendupont avatar fabiendupont commented on July 26, 2024

What about have a systemd unit in the initrd that grows the boot the root partition (growpart) and the root filesystem (growfs) before it is mounted, so that it takes the whole install disk? This could be an optional setting controlled by a kernel argument.

from centos-bootc.

cgwalters avatar cgwalters commented on July 26, 2024

https://gitlab.com/fedora/bootc/base-images/-/merge_requests/9

from centos-bootc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.