Comments (7)
cenkalti
commented on June 19, 2024
I guess the documentation is wrong. The callback_url can only be set in the app settings.
Anyway, why do you want to set it during authorization?
from github-flask.
rochacbruno
commented on June 19, 2024
I need to pass a myurl/callback/?next=/another/path
from github-flask.
cenkalti
commented on June 19, 2024
I have made the change: 6e12328
I haven't tested it yet but it should work. Make sure that you are passing a valid URL:
https://developer.github.com/v3/oauth/#redirect-urls
from github-flask.
cenkalti
commented on June 19, 2024
Did it work? If yes, I will push a new version to PyPI.
from github-flask.
HelloGrayson
commented on June 19, 2024
no tests :(
from github-flask.
cenkalti
commented on June 19, 2024
In my opinion this is a small change that does not need testing. Please re-open if not working.
from github-flask.
cenkalti
commented on June 19, 2024
I have added redirect_uri parameter to tests. 038be00
from github-flask.
Related Issues (20)
- Migrate to request headers for token authentication HOT 1
- json content detection is broken HOT 1
- Auth decorator cannot resolve github.com HOT 1
- Add conditional request support
- Pagination does not keep access_token HOT 1
- unsupported operand type(s) for +=: 'dict' and 'dict' HOT 3
- data is not supported in PUT method? HOT 2
- Get requests does not pass on query parameters HOT 2
- Look for configs in os.environ HOT 2
- Add mocking capability HOT 4
- API call return 404 error HOT 1
- Sleep mechanism for github ban HOT 1
- Can this extension be used externally by a JavaScript client?
- Doesn't work with Blueprints HOT 1
- The /user route in example.py gives me 401 Bad Credentials. HOT 2
- TypeError: __name__ must be set to a string object HOT 1
- About pagination of github.get HOT 7
- Example database just keeps on growing HOT 1
- add method to revoke token HOT 1
- expose refresh_token to authorized_handler
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-flask.