cegredev / josi Goto Github PK

Feature request: a common version use case is determining a minimum and/or maximum range of versions. It would be useful for you to add a few helper methods that do not require an explicit list.

For example, you currently have public boolean is(OS... operatingSystems). I'd suggest adding public boolean isAtLeast(OS operatingSystem).

The current implementation only includes "NT Workstation" (e.g., personal) versions and doesn't work for Windows Server versions. See JDK Source for a list of possible values for the os.name property.

There are a few tricky points to consider here:

• Some server versions are the same as the corresponding workstation version and for the purpose of matching versions, should match. For example, Vista and Server 2008 have the same feature set, so could possibly share the same enum value.
• But sharing the enum may not work for Server 2016 vs. Server 2019 where there's a distinction based on the build number
• If we do have separate enums for server version that introduces a question on how to handle the isAtLeast() checks based on enum ordering; indicating perhaps we should be keeping major/minor available for this check. But that's hard without exposing it to the API.
• Taking a look at the official Windows API for comparing versions, however, they don't handle the servers separately, they stick with essentially the same enum list you have, suggesting that for isAtLeast() the existing enum ordering is sufficient and we should just add the server versions as equivalent case staements, e.g., map "server 2008" to "vista" and so on, and consider Server 2016 and Server 2019 equivalent.

See the backronym for GNU.

Interestingly, Current OpenJDK versions only include os.name for AIX in the Unix category, having dropped support for Solaris; but it's definitely distinct from Linux. Looking in the history, they did previously include Solaris and AIX as distinct OS Types from Linux.

There should either be a separate Family for UNIX under which Solaris should fall, as well as AIX, and any other Unix flavors you want to support, or if you only want to support AIX and Solaris (matching pre-2020 OpenJDK with Solaris support) then you should add a separate family for AIX.

Should you choose to group UNIX separately, you might include the following values from os.name in older closed-source JDK versions, or versions ported to the respective OS's: FreeBSD, NetBSD, OpenBSD, DragonflyBSD, HP-UX, AIX, Solaris (also SunOS).

I'm sure the z/OS people want support too but I can't find it definitively.

Checking whether PRs break tests is currently done manually. GitHub Actions are easy to set up, very capable, and helpful to automate testing and other things. You could easily:

• Run unit tests on every push to a PR or merge to the main branch (and test across multiple JDK versions)
• Deploy SNAPSHOT versions on every merge to the main branch
• Send your code to static analysis tools like Coverity and Sonarcloud

Happy to submit a PR to get you started on this if you'd like.