A question about "CefViewClient::V8ValueToCefValue" about cefviewcore HOT 5 CLOSED

can review this commit: aa4b742

from cefviewcore.

I remember this comment was added by fixing the issue (#10).

And after debugging, I found there is mistake in this comment.

Just try the code below:

   auto v = CefV8Value::CreateInt(1000);
   auto isDouble = v->IsDouble();
   logD("isDouble: %d", isDouble);  // true
   auto isUnint = v->IsUInt();
   logD("isUnint: %d", isUnint);    // true
   auto isInt = v->IsInt();
   logD("isInt: %d", isInt);        // true

And also, there is a bug in the executeJavascriptWithResult method, I am fixing it now.

from cefviewcore.

Thanks.

from cefviewcore.

Argh! My bad. If I understand correctly in Javascript there is only one value (V8Value) of type "Number" stored as float.
https://www.w3schools.com/js/js_numbers.asp
So that's probably why "1000" will always give true in all three conditions: technically it's a "double", but it can be converted to "uint" and "int".
Excuse me, but if that is the case I see a problem with the order of your conditions: if isDouble() is always "true", this prevents the other conditions isUint(), is Int() from being reached.
So wouldn't it make sense to check the value in the order: isUint(), isInt(), isDouble()?

from cefviewcore.

uhm..... I think you are correct...will draft a fix

from cefviewcore.