Code Monkey home page Code Monkey logo

Comments (3)

john-h-kastner-aws avatar john-h-kastner-aws commented on September 15, 2024

Error one can be improved without too much effort.

Errors two and four are already fixed (#137 and #132). For error two it still prints JSON, but this is desirable IMO because that's what the user types in the schema (unless we want to create that non-json schema format :) ).

Error three relates to a broader class of poor errors from our parser. Ideally we could improve all of them at once. Regarding line numbers for schema parsing errors. There's no clear way to capture line numbers when using serde to parse JSON into our schema "CST". Adding line numbers to schema errors would be a large rework of the schema parsing code.

from cedar.

john-h-kastner-aws avatar john-h-kastner-aws commented on September 15, 2024

I looked into getting at the source locations a bit and found this: serde-rs/json#637

It definitely looks likes it's possible. There's a crate linked that does something like what we want. It's not quite exactly what we need, but the implementation shows how we could do this ourselves.

from cedar.

john-h-kastner-aws avatar john-h-kastner-aws commented on September 15, 2024

Closing in favor of #174 #175 #176

from cedar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.