Validator does not work with express router about express-openapi-validator HOT 5 CLOSED

Looks like the validator middleware only gets pushed onto the app not the routes:

express-openapi-validator/dist/index.js

        if (this.options.validateRequests)
            use.push(validateMiddleware);
        if (this.options.validateResponses)
            use.push(resOav.validate());
        app.use(use);

I imagine this is the issue.

from express-openapi-validator.

ok wow, did more digging and it turns out that the order in which the middlewares are added matters
:(

Validates correctly

const app = express();
new OpenApiValidator({
  apiSpec: './workflow-tracker-openapi.yml',
  validateRequests: true,
  validateResponses: true,
}).install(app);
app.use(bodyParser.json());
app.use(express.json());
app.use('/v1', progressRouter);

Does not validate

const app = express();
app.use('/v1', progressRouter);
new OpenApiValidator({
  apiSpec: './workflow-tracker-openapi.yml',
  validateRequests: true,
  validateResponses: true,
}).install(app);
app.use(bodyParser.json());
app.use(express.json());

from express-openapi-validator.

Let me know if you'd like me to open up a pr to talk about this in the documentation

from express-openapi-validator.

I believe the issue is the fact in the second example (Does not validate), the bodyParser middleware is setup after the routes are setup. To parse json, text, etc the parse middleware should come earlier in the chain

Assuming this is the case, perhaps, a note should be added to the documentation.

Note that I can certainly have the validator install the parser middleware automatically, however I feel the choice of parser should be left to the user and not to the library.

from express-openapi-validator.

@SpencerLawrenceBrown i've added some notes to the doc. feel free to provide feedback. thanks!

from express-openapi-validator.