Are users keyed by username? about twitter-clone HOT 6 CLOSED

@stanbar Good catch, that's definitely a bug. I didn't realize that the id for the user on firestore is using guid instead of username.

Thanks @Ketchupchh for the fix on the PR.

from twitter-clone.

@Ketchupchh

It's not a matter of preference. It's a bug that causes two users to have the same username.

Actually I found another problem with the file id. It's present in your PR as well #42

from twitter-clone.

I'm not sure if I get exactly what you're asking (I have not been to sleep in a long time) but the code you're referencing is to check if there's a user in the database that already goes by that username. They're shouldn't be duplicate usernames in the database. Correct me if I didn't fully understand your question, sorry.

from twitter-clone.

@Ketchupchh Haha, no problem 😄

My point is that you are checking username uniqueness on the document's key level. Instead you should check it on the document's username field level.

Wrong:

Good:

      const randomUserSnapshot = await getDocs(
        query(usersCollection, where('username', '==', randomUsername))
      );
      if (randomUserSnapshot.empty) available = true;

Does it make sense now?

from twitter-clone.

Oh I get what you're saying now. I definitely would've done the latter. I'm quite new to Firestore but I think it probably just boils down to preference atp no? Unless @ccrsxx had reason for doing it the way he did(?)

I know he's a busy fella so if he wants to make the change I'm more than happy to add it to my pull request.

from twitter-clone.

Fixed in #40

from twitter-clone.