Code conversion to JavaScript about meteor-subs-cache HOT 35 CLOSED

Great @Fen747, thanks.

And @ccorcos, I think the best thing is first merge those pending Push Requests. Then I can try to convert it to JS.

What do you think? We have tested some of those PRs and think I can safely merge them.

from meteor-subs-cache.

@paranoico , we went ahead and converted to vanilla JS. Interested in a PR?

from meteor-subs-cache.

Thanks @paranoico, we already translated to JS and using in production. Between today and tomorrow we should have PR ready

from meteor-subs-cache.

Maybe atmosphere is not the best way to maintain it since Meteor is moving away from their packages and toward NPMs. I needed this to use this with connections so I ran the code through decaffeinate made the quick change and added to my common-lib npm module for my projects. So, proof it is possible.

from meteor-subs-cache.

Really sorry --- too much work :)
It's already converted, just need to test it as a package (right now we embedded directly into our app).

Today, pinky promise!

from meteor-subs-cache.

You are more than welcome to convert it to JS -- shouldnt be too hard.

from meteor-subs-cache.

Thanks a lot, let me then try to understand it first. Regards.

from meteor-subs-cache.

Hi,

I'd too liked to convert this project to javascript, and propose to help keeping the repo alive.

from meteor-subs-cache.

What we need to do is: (1) figure out how to give you guys publishing access to publish to the meteor packaging system and (2) I'll give you guys access to the repo so you can merge them yourselves :)

from meteor-subs-cache.

Precisely, yes of course we need access, we can do the merge. And everything else.
You can set up us as collaborators to the project or some other permissions as team members.
But I am afraid that only you can do it.

from meteor-subs-cache.

@paranoico added you as a collaborator

from meteor-subs-cache.

Thanks @ccorcos, will start to check it.

from meteor-subs-cache.

Hello @ccorcos, I have done 2 PRs and now it is necessary to update Meteor Package, ¿can I do it also? ¿Or how do we proceed?

from meteor-subs-cache.

from meteor-subs-cache.

@ccorcos I think this could help:
http://stackoverflow.com/questions/29267399/how-to-add-collaborator-for-meteor-package-in-atmosphere

from meteor-subs-cache.

~ ❯❯❯ meteor admin maintainers ccorcos:subs-cache --add paranoico
Please log in with your Meteor developer account. If you don't have one, you
can quickly create one at www.meteor.com.
Username: ccorcos
Password:
Adding a maintainer to ccorcos:subs-cache...

The maintainers for ccorcos:subs-cache are:
ccorcos
paranoico

all yours :)

from meteor-subs-cache.

Hi @paranoico - as heavy users of this package, we are very happy to hear there is a new maintainer.

Would it be possible to remove the warning in the README now (so as to avoid discouraging other users)?

from meteor-subs-cache.

Hello @ramijarrar , it is done. Thanks.

from meteor-subs-cache.

@ramezrafla Could you please release the code in your own repo ? It doesn't seems that this one is going to revive anytime soon, and I'm interested in having a full JS version of this package. Thanks you.

from meteor-subs-cache.

Ok, will do. @paranoico - do you want to add me as maintainer instead?

from meteor-subs-cache.

Hello @ramezrafla , I think I cannot add maintainers, I am not the owner.

But please make a Push Request.

And sorry, we have not had time enough to follow project in weeks. I just merged several PRs a month ago and released new package to Atmosphere. @Fen747 is not informed properly.

from meteor-subs-cache.

@ramezrafla How about if I create a new branch for your PR? In order to test conversion properly before uploading to Atmosphere.

from meteor-subs-cache.

@paranoico, please do. Thanks!

from meteor-subs-cache.

@ramezrafla Ready, new branch is named JS-Migration, there I am going to merge your PR.

from meteor-subs-cache.

Good to know it is now maintained again :). I am also willing to help if the code gets converted to JS too.

On a side note, I was using the fork from @ElvishJerricco since it was more updated, and now that I see this is becoming the main one, I have noticed there are some commits in the fork that are not present in this repo.
Maybe it would help to copy those changes in this repo too? (If it's not possible to get PRs from the author).

Some important examples

• ElvishJerricco@03c38ad
• ElvishJerricco@e310ce5
• ElvishJerricco@bd05cde

from meteor-subs-cache.

Thanks! I'll start preparing the package to PR. Give me a couple of days, as right now, we extracted the main js out of the package and directly embedded in our app.

from meteor-subs-cache.

Thanks @tcastelli ,
We are going to check ElvisJerrico changes, In matter of fact we already saw that he had several additional changes but wanted to saty with Ccorcos version since there was a specific functionality we needed.

from meteor-subs-cache.

Thanks to you @ramezrafla ,
Take your time, I think it will be in a week or two when we can make our first try to translate to JS.

from meteor-subs-cache.

@ramezrafla what's the status for the code conversion? :)

from meteor-subs-cache.

PR #34 submitted - please look at the notes. Testing of package.js needed (sorry, no time and I didn't want to keep holding others back)

from meteor-subs-cache.

The atmoshphere package is not updated yet right?
https://atmospherejs.com/ccorcos/subs-cache

It published the old coffeescript package.

from meteor-subs-cache.

@lmachens that is correct, atmosphere package has not been updated yet, since we have not finished testing of new JS code. I do not want to break the working Coffeescript until we are sure the new one works well. Until we test it on field operations and have no issues I will be willing to update atmosphere.

Have you tested JS code already on your application?

from meteor-subs-cache.

No, but I had problems to set up this package.
Readme.md:
meteor add ccorcos:subs-cache

subsCache = new SubsCache(5, 10);

This will not work until you update the atmosphere package.
The constructor in the coffeescript packae is different:
subsCache = new SubsCache({ expireAfter: 5, cacheLimit:10});

from meteor-subs-cache.

You are right, there are differences, Readme was updated when master branch was updated.

We are trying to release new version on 20 mobile devices to test it on field on 2 weeks.

from meteor-subs-cache.

Today Atmosphere package has been updated with last version. Thanks all for your help and patience.

from meteor-subs-cache.