Initialization with empty string issue about marqueelabel HOT 4 CLOSED

I'm not seeing the issue as you describe it, although I don't see any downside (at a first glance) to making the change. Could you post a bit more of your code? Like how you're setting up the label and where exactly you set it to @"" the first time? Also setting the labelText to [NSString string] is actually the same as setting it to @"" (because [[NSString string] isEqualToString:@""] == YES)

from marqueelabel.

Ok..let me give you an example:

I have the following code in viewDidLoad:

_label = [[MarqueeLabel alloc] initWithFrame:CGRectMake(30, 100, 100, 30) duration:5.0 andFadeLength:25.0];
[_label setText:@""];// initially no text should be displayed
[_label setBackgroundColor:[UIColor yellowColor]];
[self.view addSubview:_label];

where _label is an instance variable.

Then I have an UIButton and the corresponding IBAction (on UIControlEventTouchUpInside event):

• (IBAction) dummyButtonPressed:(id)sender
  {

     [_label setText:[[_label text] stringByAppendingString:@"M"]];
  

  }

If self.labelText is set to nil (as currently is: self.labelText = nil in - (void)setupLabel method from MarqueeLabel), then the line of code [_label setText:[[_label text] stringByAppendingString:@"M"]]; has no effect --> no text is displayed no matter how many times I press the button...BUT if you change the self.labelText = nil; to self.labelText = [NSString string]; (in - (void)setupLabel method from MarqueeLabel.m) everything works as expected.

Hope now everything is more clear..

Regards,
Calin B.

from marqueelabel.

Ah, gotcha, I see what you mean - the problem is showing up because of using the stringByAppendingString: method on [_label text]. The property text just returns self.labelText, which at that point is nil so stringByAppendingString: does nothing.

Good catch, thanks! The latest commit should fix your problem, although I'm using self.labelText = @"" just so it's explicitly obvious it's being set to an empty string in setupLabel.

from marqueelabel.

Glad to help.

from marqueelabel.