Comments (16)
Yep, no development is going on, feel free to create a PR
from terraform-aws-gitlab-runner.
@roock cool idea, any idea thoughts for an implementation?
from terraform-aws-gitlab-runner.
some thoughts:
- we would need to aquire an static Elastic IP address
- we could assign this IP with the following script: https://github.com/skymill/aws-ec2-assign-elastic-ip
- we would need an additiona parameter to add a rule to the security group for allowing Gitlab to the websession port
from terraform-aws-gitlab-runner.
Oh yes, a feature I missed already. Guess no work is going on at the moment, right?
from terraform-aws-gitlab-runner.
The EIP is assigned to the runner agent. #124 will not be solved here.
I will also offer the possibility to add a rule to a load balancer instead of assigning an EIP.
from terraform-aws-gitlab-runner.
I reviewed my last comment and think that it makes no sense to add an IP or load balancer or something else. The reason is, that you should already been able to reach the runner from your gitlab instance (to start the build jobs).
from terraform-aws-gitlab-runner.
I reviewed my last comment and think that it makes no sense to add an IP or load balancer or something else. The reason is, that you should already been able to reach the runner from your gitlab instance (to start the build jobs).
Afaik there is a difference between regular runner jobs and the session Server. For regular jobs, the runner will establish a http connection to the gitlab server. For the session server, Gitlab will establish a (tls-encrypted) connection to the runner, so you will need to expose the session service to Gitlab.
from terraform-aws-gitlab-runner.
Oh yes, you are absolutely right. I will add options for an IP address and a load balancer (ALB, ELB do not work here, see https://docs.gitlab.com/ee/administration/integration/terminal.html#enabling-and-disabling-terminal-support)
from terraform-aws-gitlab-runner.
The module already supports adding an EIP directly to the instance. Not sure if it is strictly required to put it behind a ALB, although it might be a more elegant solution.
from terraform-aws-gitlab-runner.
@roock Yeah, just saw it. So nothing to do for the EIP. An ALB listener can now be passed to the module. But the test is still missing. The idea is to use either EIP or ALB. Depends on your preferences, company guidelines, ...
from terraform-aws-gitlab-runner.
Hm, still on my wishlist. Using an ALB is too complicated. Let's stick with the EIP solution which is already in place.
from terraform-aws-gitlab-runner.
Ok, let's give it another try. Stick with EIP for the base feature and add ALB support later.
from terraform-aws-gitlab-runner.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.
from terraform-aws-gitlab-runner.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.
from terraform-aws-gitlab-runner.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.
from terraform-aws-gitlab-runner.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.
from terraform-aws-gitlab-runner.
Related Issues (20)
- Security: registration token is stored in plan text in user-data HOT 2
- Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock HOT 11
- Custom Ingress Rules for Prometheus Port are not possible HOT 2
- Proper logs for runner lifecycle events and errors
- AccessControlListNotSupported: The bucket does not allow ACLs
- 403 forbidden error when using cache with the "docker" runners executor
- Breaking Change: Migrate to v7 HOT 14
- runner_user_data can not output nonsensitive value HOT 5
- Unable to create Spot Fleet request HOT 4
- Not sure what to do here, module.runner.module.cache[0].aws_s3_bucket.build_cache HOT 1
- Shared cache for multiple runners HOT 2
- Stuck on module.runner.module.cache[0].aws_s3_bucket.build_cache: Still creating... HOT 4
- Registration Token is deprecated / Add support for "Next GitLab Runner Token Architecture" HOT 11
- Support MaxGrowthRate HOT 4
- What is the easiest way to cache docker images pull? HOT 12
- "key_pair_name" is not expected here HOT 1
- Gitlab Runner Fleet Setup not working properly "Instance ID is malformed" HOT 8
- Unable to communicate with AWS APIs due to security group restrictions when VPC endpoints are enabled with gitlab_runner module HOT 6
- Unable to provision EC2 instances: "Tag key must have a value" HOT 2
- Add module.cache.policy_arn to outputs for other gitlab runner module to reference HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-gitlab-runner.