Code Monkey home page Code Monkey logo

Comments (4)

npalm avatar npalm commented on June 11, 2024

@eliasdorneles thanks for reporting the issue. First idea that I have is to do a md5sum check, md5sums are available at the github release page https://github.com/docker/machine/releases

Do you have another idea?

from terraform-aws-gitlab-runner.

eliasdorneles avatar eliasdorneles commented on June 11, 2024

Good idea, downloading the md5sum from https://github.com/docker/machine/releases/download/v${docker_machine_version}/md5sum.txt and then checking the file against it sounds great! 👍
Of course then md5 file download can fail, but we'd have a stronger guarantee.

Another idea (just whispered to me by @allan-simon) could be adding a docker_machine_url to allow users to host their docker machine binary themselves.

What do you think?

from terraform-aws-gitlab-runner.

npalm avatar npalm commented on June 11, 2024

@eliasdorneles @allan-simon sounds good. In case the md5sum is invalid, a md5sum check will fail ass well. Another idea could be add the the -f option to curl to let it fail.

from terraform-aws-gitlab-runner.

eliasdorneles avatar eliasdorneles commented on June 11, 2024

Oh yeah, that sounds like the minimal code which will reach most of the benefit, since it will show up in the logs and make the problem quicker to find. 👍
We can also enable retries -- I'll send a quick PR.

from terraform-aws-gitlab-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.