can't enable ssh access to the runner instance about terraform-aws-gitlab-runner HOT 3 CLOSED

@philippefuentes thanks for reporting the issue, will check it this week

from terraform-aws-gitlab-runner.

@npalm I also noticed that the runner_ssh security group does not have any egress attached.

So in the end what I did is getting rid of the additional runner_ssh sg and simply attached the runner_ssh sg rule to the existing runner sg (it's already got an egress configured) according to the value of enable_gitlab_runner_ssh_access:

resource "aws_security_group_rule" "runner_ssh" {
  count = "${var.enable_gitlab_runner_ssh_access ? 1 : 0}"

  type        = "ingress"
  from_port   = 22
  to_port     = 22
  protocol    = "tcp"
  cidr_blocks = ["${var.gitlab_runner_ssh_cidr_blocks}"]

  security_group_id = "${aws_security_group.runner.id}"
}

So basically, you'll notice that in the updated code above, security_group_id refers to the runner sg instead of the former runner_ssh sg that I deleted, I think this is what is expected.

from terraform-aws-gitlab-runner.

Yep thanks, the security group runner_ssh is not used at all. Busy with a fix

from terraform-aws-gitlab-runner.