Comments (12)
npalm
commented on June 3, 2024
@bsuv feel free to propose a PR. I use the runners in a private subnet, so no public ones are attached.
from terraform-aws-gitlab-runner.
bsuv
commented on June 3, 2024
I will work on a PR. The issue with having them in a private subnet is that the NAT Gateway costs can become prohibitive
from terraform-aws-gitlab-runner.
roock
commented on June 3, 2024
related issue #92
from terraform-aws-gitlab-runner.
roock
commented on June 3, 2024
I've started working on this issue: roock@c204e4b
i t is working when enabling the use of EIP, but for disabling the feature I need a way to reference a non existing object (aws_eip is only create if the flag is set)
seems to work fine, tested with runner on public subnet with and without flag enabled @npalm what do you think?
from terraform-aws-gitlab-runner.
kostyrev
commented on June 3, 2024
@roock do not hard code region and please do rebase from upstream and open PR
from terraform-aws-gitlab-runner.
roock
commented on June 3, 2024
@kostyrev ups, thx for the hint
from terraform-aws-gitlab-runner.
roock
commented on June 3, 2024
Assignment of EIP to the Runner server itself was added in #161 and #165. Not sure if it is possible to add support for EIPs for the docker-machine servers though.
from terraform-aws-gitlab-runner.
npalm
commented on June 3, 2024
@roock seems not supported by the aws docker machine driver https://docs.docker.com/machine/drivers/aws/
from terraform-aws-gitlab-runner.
roock
commented on June 3, 2024
A possibility would be to use the user_data to assign an EIP to the docker-machine instances.
from terraform-aws-gitlab-runner.
kayman-mk
commented on June 3, 2024
Is it really necessary to expose the runners? You could also access your machines via AWS Console (SSM access). Seems to be easier to configure and less risky.
If we are talking about the agent: There should be an inbound rule which allows traffic from your Gitlab instance only. And the communicatin agent <-> runner should be safeguarded through the module itself using security groups.
We should be fine without an EIP at all or do I miss something? Any other use case?
from terraform-aws-gitlab-runner.
github-actions
commented on June 3, 2024
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.
from terraform-aws-gitlab-runner.
github-actions
commented on June 3, 2024
This issue was closed because it has been stalled for 15 days with no activity.
from terraform-aws-gitlab-runner.
Related Issues (20)
- remove_gitlab_registration script doesnt run on termination of instance HOT 9
- Support shell and/or instance executor HOT 6
- "Error: Output refers to sensitive values" when applying fleet configuration HOT 1
- shared named volume through stages HOT 1
- Errors prepare environment failed at cannot connect to Docker daemon HOT 6
- Migrating from 6.5.1 to 7.1.1 - Migration script provided fails HOT 7
- Worker runners not working on public subnet
- Option to gracefully terminate runner HOT 10
- Using `nonsensitive` in `runner_user_data` variable causes `terraform plan` to fail HOT 2
- No route to host after scripts of job HOT 7
- Docker Machine executor retired HOT 1
- Since version 7.2.1 the old registration model no longer support removing the registration_token from the module HOT 4
- Documentation Has Non-Existant Variables Referenced HOT 2
- Missing the addition of the GetParameter policy to be able to retrieve a parameter from SSM
- 'remove-gitlab-registration' script can invalidate in-use runner authentication token HOT 10
- issue with pull_policies HOT 3
- v7.2.3 not available on Terraform Registry HOT 17
- Terraform destroy doesn't work HOT 5
- Module update removes registered runner but does not create a new runner HOT 5
- Add ipv6 support HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-gitlab-runner.