Contribution about py3gpp HOT 6 CLOSED

Hi,

1. yes I think that would be good
2. I don't understand that, can You give an example of a "MATLAB reference"?

from py3gpp.

I don't understand that, can You give an example of a "MATLAB reference"?

Example:
https://github.com/vborchsh/pynrl1/blob/develop/tests/test_nrPBCH.py

In this test I use Python's matlab.engine for call MATLAB functions such as eng.nrPBCH(...) literally from MATLAB. Then, I use MATLAB arrays to check my Python's implementation.

Details about MATLAB API:
https://www.mathworks.com/help/matlab/matlab-engine-for-python.html

from py3gpp.

Ah I see. Yes I think it does not hurt if they are kept in the code, as long as there are still pure python tests which can run without Matlab.
I had a quick look at Your code, so far the things You implemented look fairly identical to the ones I did. What is Your plan for implementing next?

from py3gpp.

I concentrated on downlink part. So, I'm going to implement PDSCHDMRS+Indices, PDSCHPTRS+Indices and PDCCH+Indices functions to cover my current work. Then - PDSCH in general, probably, with limited functionality in the beginning.

Plus certain configuration classes, needed for mentioned functions.

from py3gpp.

that sounds good. PRs are welcome.

from py3gpp.

Ok, let me close current issue and I'll come back later with PRs. Thanks!

from py3gpp.