Code Monkey home page Code Monkey logo

Comments (5)

catamphetamine avatar catamphetamine commented on May 21, 2024

Ha ha, interesting bug you found.
So, what it does is it intercepts all require(.json)s and tries to load those Json files from webpack-assets.json.
I've updated the package.
The new version should fix the error, try it.

from webpack-isomorphic-tools.

happypoulp avatar happypoulp commented on May 21, 2024

Works perfectly! Just for curiosity, how does it come that I did not reproduce this issue in the well known universal example (that is also using the json-loader): https://github.com/erikras/react-redux-universal-hot-example ? I can't figure it out what I did differently to trigger the issue...

Thanks a lot for webpack-isomorphic-tools and for your quick fix!

from webpack-isomorphic-tools.

catamphetamine avatar catamphetamine commented on May 21, 2024

@happypoulp because they're not using "json" asset extension
https://github.com/erikras/react-redux-universal-hot-example/blob/master/webpack/webpack-isomorphic-tools.js#L15

from webpack-isomorphic-tools.

happypoulp avatar happypoulp commented on May 21, 2024

I see now. I did not understood that the assets of webpack-isomorphic-tools config was the one that triggered handling of require by webpack-isomorphic-tools server-side .

Thanks!

from webpack-isomorphic-tools.

catamphetamine avatar catamphetamine commented on May 21, 2024

FYI
I'm posting this in every issue and PR to notify whoever may be interested:
today I've released an alternative helper library called universal-webpack.
It takes a different approach than webpack-ismorphic-tools and instead of hacking Node.js require() calls it just compiles all code with target: 'node' webpack configuration option.
As a result, all Webpack plugins and features are supported.
If you think you might need that here's an example project:
https://github.com/halt-hammerzeit/webpack-react-redux-isomorphic-render-example

from webpack-isomorphic-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.