Comments (7)
I can confirm that this is not the case, all files changed by cargo +nightly fmt
(idk if nightly matters here) are changed from crlf to lf. Look like it is an open bug in rustfmt: rust-lang/rustfmt#4097
Some git magic later it's all fixed but these are the kind of rough edges that confirm my biases against rustfmt
from pelite.
It took some time but it's there
from pelite.
The other option is to disable rustfmt project-wide with disable_all_formatting in the .rustfmt.toml, though I'd suggest that it's better to pick a suboptimal style rather than ad-hoc style chosen by contributors
from pelite.
I would PR this, but it would be difficult to review due to the large number of changes, so I'll leave it up to the maintainer to push a version with cargo fmt
run on it
from pelite.
Thanks for your consideration! I've been working on implementing a rustfmt policy that I can stomach.
I'm not a fan of autoformatters in general as they tend to make everything look consistently ugly.
But with some okay settings, a nightly rustfmt, refactoring some code and liberal application of rustfmt::skip
I think I can make it work.
I'll try to get a PR up in a few more hours.
from pelite.
Good lord I just noticed rustfmt rewrote everything to lf which conflicts with my windows checkout and usage of autocrlf setting... I'll try to keep going and get the repo to cleanly pass rustfmt but rustfmt is just not ready for actual usage...
from pelite.
You can adjust this with the newline_style setting.
Looks like the default is "auto" though which tries to use whatever that file already uses, so your file probably already had a LF present.
from pelite.
Related Issues (20)
- Missing documentation on pattern macro
- Resources documentation is a mess
- Windows defender detects `tests\pocs\blob` as Trojan:Win32/Fuery.B!cl HOT 6
- Add json output to pedump HOT 1
- Read please!
- fchghfhfghxd
- Sample does not work since last pull (master) HOT 2
- New version of pelite-macros broke 0.8.1 HOT 3
- no `pattern_attribute` in the root HOT 2
- Misaligned address when trying to access Import section of some PEs HOT 4
- crates.io lists pelite as a command when it is a library HOT 1
- Add pelite::Wrap to the top level crate documentation HOT 2
- Writing to imports HOT 3
- UNWIND_INFO and unwind_info() is broken HOT 1
- Unable to read PE version on Linux HOT 5
- VersionInfo.fixed() return None while version info does exist HOT 5
- 32-bit linux build broken HOT 2
- Please help me get the version of the file in string format HOT 1
- Incorrect module base address used for PE32 mapped images using ASLR
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pelite.