React 0.14 about reactcss HOT 10 CLOSED

Do you know what the is="..." attribute does? I cant find anything about it.

Also, since the react-map-styles is doing string replace, it wont break anything unless you are trying to use is. I have been trying to come up with a more long-term solution other than hijacking it anyways.

from reactcss.

no idea, i just was reading the new react documentation and thought of
this.

i meant more of "conflict" than break. i'll see if i can lookup anything
about "is"

On Tue, Sep 29, 2015 at 8:39 PM case [email protected] wrote:

Do you know what the is="..." attribute does? I cant find anything about
it.

Also, since the react-map-styles is doing string replace, it wont break
anything unless you are trying to use is. I have been trying to come up
with a more long-term solution other than hijacking it anyways.

—
Reply to this email directly or view it on GitHub
#22 (comment)
.

from reactcss.

There is another issue related to React 0.14. Should I post it here or create a new issue?

from reactcss.

Seems like react is enforcing that all react components extend React.Component directly.

class MyComponent extends ReactCSS.Component {
  render(){
    return <div />
  }
}

throws this warning:

Warning: MyComponent(...): React component classes must extend React.Component

from reactcss.

Found out that the is="..." syntax is for web component support and not recommended by Facebook so we should be fine on that front.

https://twitter.com/soprano/status/651880693748899840

from reactcss.

Looking into the component classes error as we speak.

from reactcss.

Don't know if the component classes issue is really an issue?

The warnings appear, because reactcss has a dependency to react 0.13. That version does not have "isReactComponent" flag set for the React.Component class from which ReactCSS.Component inherits. When I updated reactcss' dependecy to react 0.14, the warnings disappeared and everything works just fine.

Here is the code that React uses to validate the inheritance:
warning(Component.prototype && Component.prototype.isReactComponent || !canInstantiate || !(inst instanceof Component), '%s(...): React component classes must extend React.Component.', Component.displayName || Component.name || 'Component')

The above happens only with the npm package. In master this seems to have been fixed. @seekshiva Are you on master or version 0.4.x?

from reactcss.

@casesandberg sorry for blending this and #23 together. @jhytonen is right, I upgraded to the version on master and the warnings etc. have gone away. everything seems to be working well.

from reactcss.

@casesandberg Would it be possible for you to release a version of reactcss with the dependency fixed?

from reactcss.

Dependency has been fixed in [email protected]

from reactcss.