Code Monkey home page Code Monkey logo

Comments (3)

casesandberg avatar casesandberg commented on June 1, 2024

@liady only problem is you can't declare it in your component if its already in the mixin and its necessary if you want to add arguments to it.

from reactcss.

liady avatar liady commented on June 1, 2024

@casesandberg Yeah, I see the problem.

Theoretically it could be:

ReactCSS.mixin.styles = function(){
  return this.css(this.conditionalClasses && this.conditionalClasses.call(this));
}

and when using this mixin:

var Item = React.createClass({
  mixins: [ReactCSS.mixin],
  // totaly optional now:
  conditionalClasses: function(){
    return {"hovered": this.state.hovered}
  }

And that way conditionalClasses will be an optional key only for those who want to declare conditional classes rules. All the rest won't have to declare styles at all.

But now it will probably be a breaking change for those who are already using it.

from reactcss.

casesandberg avatar casesandberg commented on June 1, 2024

Yeah, but then the ES5 and ES6 versions are structured differently. I wanted to keep them as similar as possible until ES6 becomes the standard.

from reactcss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.