Comments (3)
@liady only problem is you can't declare it in your component if its already in the mixin and its necessary if you want to add arguments to it.
from reactcss.
@casesandberg Yeah, I see the problem.
Theoretically it could be:
ReactCSS.mixin.styles = function(){
return this.css(this.conditionalClasses && this.conditionalClasses.call(this));
}
and when using this mixin:
var Item = React.createClass({
mixins: [ReactCSS.mixin],
// totaly optional now:
conditionalClasses: function(){
return {"hovered": this.state.hovered}
}
And that way conditionalClasses
will be an optional key only for those who want to declare conditional classes rules. All the rest won't have to declare styles
at all.
But now it will probably be a breaking change for those who are already using it.
from reactcss.
Yeah, but then the ES5 and ES6 versions are structured differently. I wanted to keep them as similar as possible until ES6 becomes the standard.
from reactcss.
Related Issues (20)
- Remove react-addons-test-utils from peerDependencies HOT 8
- react-addons-test-utils still in published 1.0.8 HOT 1
- Custom selectors that are vendor specific HOT 2
- Pass in onClick component for Hover
- how to used Autoprefixing ? HOT 1
- Autoprefix returning empty list under webpack2 HOT 2
- Build fails while using with react-color component HOT 5
- Make Autoprefixing Exhaustive
- Proposal: Support for symbols
- Redux Compatibility? HOT 4
- Put react in dependencies cause npm install different react version, HOT 1
- Tag releases please HOT 1
- Hover.js > hover.js HOT 1
- ReactCSSTransitionGroup example HOT 5
- Is Hover broken? HOT 3
- Why is there an example titled Redux? HOT 1
- Pseudo-classes are not pseudo-elements (documentation nitpick) HOT 1
- Remove lodash as a dependency and use lodash 4.0 submodules as needed HOT 2
- Input Placeholder Color HOT 1
- Write type declaration file for typescript HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactcss.