Comments (4)
Hi @sadayuki-matsuno ,
I have added 3 optional functions in Xorm Adapter:
AddPolicy()
RemovePolicy()
RemoveFilteredPolicy()
These functions will provide the auto-save functionality (aka save the policy line by line).
Please see details in: https://github.com/casbin/casbin/wiki/AutoSave
from xorm-adapter.
Hi @sadayuki-matsuno ,
This is also one thing that I got in my mind. I think we can add functions like AddPolicy()
and RemovePolicy()
to the adapter interface. But one issue is that there are still adapters that can't operate on line level. For example:
- the protobuf adapter regards all policy rules as a string.
- The same with KV store adapters, all policy rules are stored in one key.
So these adapters can't gain from the two calls, because they still need to save-all and load-all. If I add these two calls to the adapter interface, all other adapters have to support them too. One way to solve is using an empty implementation. So I think it's still doable.
What do you think about this way?
from xorm-adapter.
I understood. This is so complicated.
Using an empty implementation is good for me,
because KV stores also have more options to process one line at a time.
from xorm-adapter.
Thank you so much!
from xorm-adapter.
Related Issues (20)
- Is it necessary to add 'p_type' tag to compatible the old version? HOT 1
- the func SavePolicy will drop table? HOT 2
- xorm is moving to gitea.com HOT 1
- panic: interface conversion: *xormadapter.Adapter is not persist.Adapter: missing method LoadPolicy HOT 9
- fail to mssql HOT 2
- Adapter.SavePolicy() not safe for concurrent use? HOT 6
- Implement UpdatePolicy() API (aka UpdatableAdapter interface) HOT 1
- Interface conversion (Panic) *xormadapter.Adapter is not persist.UpdatableAdapter: missing method UpdatePolicies HOT 2
- SavePolicy reports "No element on slice when insert" error when the model's policy is null HOT 10
- Switch to GitHub Actions CI and add semantic-release HOT 2
- Missing method UpdateFilteredPolicies HOT 4
- Support table prefix HOT 2
- UpdateFilteredPolicies returns the oldPolicy containing ptype, Is this a bug? HOT 6
- README is wrong (for v1 only) HOT 1
- [BREAKING CHANGE] Rename PType to Ptype like gorm-adapter HOT 2
- [Question] Can I configure casbin xorm to "skip" table creation ? HOT 7
- Fails to connect to pg 16.1 HOT 5
- xorm-adapter v2 not find HOT 2
- feature: fix the context adapter feature HOT 1
- occur err when using dameng HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xorm-adapter.