I want to store a policy in DB each time. about xorm-adapter HOT 4 CLOSED

Hi @sadayuki-matsuno ,

I have added 3 optional functions in Xorm Adapter:

1. AddPolicy()
2. RemovePolicy()
3. RemoveFilteredPolicy()

These functions will provide the auto-save functionality (aka save the policy line by line).

Please see details in: https://github.com/casbin/casbin/wiki/AutoSave

from xorm-adapter.

Hi @sadayuki-matsuno ,

This is also one thing that I got in my mind. I think we can add functions like AddPolicy() and RemovePolicy() to the adapter interface. But one issue is that there are still adapters that can't operate on line level. For example:

• the protobuf adapter regards all policy rules as a string.
• The same with KV store adapters, all policy rules are stored in one key.

So these adapters can't gain from the two calls, because they still need to save-all and load-all. If I add these two calls to the adapter interface, all other adapters have to support them too. One way to solve is using an empty implementation. So I think it's still doable.

What do you think about this way?

from xorm-adapter.

I understood. This is so complicated.
Using an empty implementation is good for me,
because KV stores also have more options to process one line at a time.

from xorm-adapter.

Thank you so much!

from xorm-adapter.