User should define database about gorm-adapter HOT 13 CLOSED

I don't recommend the adapter to create DB, so I want to remove the code.

What do you think? @hsluoyz

from gorm-adapter.

Creating DB is our tradition. And it makes it easy for testing like running on CI. Keeping it would be better if it doesn't bring too much trouble.

from gorm-adapter.

We can refactor out the DB name as an arg.

from gorm-adapter.

Well I don't have hard feelings about the DB creation. However, our infrastructure already provides the DB and we want to have full control of it. I'm happy to let Casbin create the tables within it, but the rest should be config IMO.

from gorm-adapter.

Well I don't have hard feelings about the DB creation. However, our infrastructure already provides the DB and we want to have full control of it. I'm happy to let Casbin create the tables within it, but the rest should be config IMO.

Have you tried NewAdapterByDB or NewAdapterByDBUsePrefix methods? You can provide your DB objects as a parameter

You would just be responsible for creating the Database, while casbin adapter will ensure that the table is created

from gorm-adapter.

@rico-ci the adapter can also re-use existing DB. It's totally an open option.

from gorm-adapter.

Hi there! Thanks for the links and the clarification. I wasn't aware of the other adapters. I still feel that those table values should not be hard-coded and left to the user to define.

I initially opened this issue as I started working on the Casbin-server (CaaS). I observed this behavior out-of-the-box while expecting that my config.json would be parsed fully and the DB accesses / created accordingly.

from gorm-adapter.

Should we make the dbname and tablename to left to the user to define? @hsluoyz @nodece

from gorm-adapter.

@00LT00 Yes. dbname and tablename will be optional args. So if user doesn't specify them, we still use current as default values.

from gorm-adapter.

@00LT00 Yes. dbname and tablename will be optional args. So if user doesn't specify them, we still use current as default values.

I'm try to fix it.Now I have some little problems ...

from gorm-adapter.

Sorry for not being active here the past week @hsluoyz. But seems like there's progress on this issue. Cheers!

from gorm-adapter.

@hsluoyz @nodece @rico-ci User can define dbname and tablename

from gorm-adapter.

Fixed in: #43

from gorm-adapter.