Code Monkey home page Code Monkey logo

Comments (6)

borja-munoz avatar borja-munoz commented on August 20, 2024

I understand the use case but I'd like to know what will happen if the user changes the viewport. In this case, you will have a widget showing data that might not match with the features displayed in the map. You could also have some widgets with interactivity set to true but, if you filter using these widgets, the other widgets will remain static. Should we mark/label the not interactive widgets in any way?

I think it is important to have also feedback from Product Design here: @javigil-geo @josegilg

from carto-react.

Clebal avatar Clebal commented on August 20, 2024

A property called filtering/interactivity just involves the filter that the widget applies, not the viewport filter. Viewport filter will be always applied since there's not an explicit prop for that, but that's what we're talking about.

When filtering/interactivity is disabled, the widget won't raised any event when the user clicks in a certain category. I don't think it needs some special kind of mark/label.

from carto-react.

borja-munoz avatar borja-munoz commented on August 20, 2024

OK, so the widgets are not really static. They are updated if the viewport changes or there are new filters applied to the source, right? If that's the case, I am not sure how it works with the concept of the analysis you are mentioning.

Let's wait to have the feedback from Product Design to see what they propose.

from carto-react.

Clebal avatar Clebal commented on August 20, 2024

They are static as far as you cannot interact with the widget. I know that static can have many meanings. Static widgets can be filtered by viewport filters and source filters, the only difference is that static widget cannot apply filters.

Okey, I'll wait.

from carto-react.

VictorVelarde avatar VictorVelarde commented on August 20, 2024

I think this makes a lot of sense. To be honest I think that we already had this feature on (I think we had it in the past). It's probably also quite easy to integrate

from carto-react.

borja-munoz avatar borja-munoz commented on August 20, 2024

I've already talked with @josegilg and we just need to make some minor changes to the widgets design, so the RFC is approved for implementation.

from carto-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.