Comments (2)
The rule says Declare functions for operations that require more that one step
. In that example, the function contained just one step, thus making it redundant to add an extra wrapper function. I don't see how the example was incorrect.
Withe these changes, the recommended example goes against the statement of the rule
from protractor-styleguide.
One line may be more then 1 step.
user.name.sendKeys('TeddyB');
means select name
field, and send keys parameter
its like 2 steps.
For example if the logic : input name
, will be more complex (name in form is not a good example, but let say is will be more complex somehow), you will need to change all places where you used this 'double step' line. With a special function for the logic its just a function content change.
btw. the function enterName
should return
the statement, in case the user of such function want to use promises etc.
and even if my PR were wrong, then the rule description should be like dont use function for one line code
. Because it is what the code shows. Use function for more than one step
is not represented in the example. So its probably just inverted and my PR is right :)
from protractor-styleguide.
Related Issues (20)
- Add rule about phrasing
- Add section about helpers
- Update examples to latest Protractor version
- Update section about Page Objects
- Remove unnecessary tasks from the Gruntfile and update package.json accordingly
- A few minor issues I have HOT 1
- Sugar Step for E2E Testing and Test Tags for Mocked E2E HOT 1
- Thanks for style guide... HOT 2
- Please advice independent tests HOT 2
- Enforcing style guide rules HOT 3
- Require all for page objects HOT 1
- Rule 14: does double export make sense? HOT 2
- Type Over in code - documentation HOT 2
- This project may need an additional maintainer HOT 10
- Rule-15 missing recommended example HOT 1
- Rule-22: Second bullet should read as an aside/note
- set global variables in a file - not in conf file HOT 3
- conditional cases HOT 2
- Add info about Protractor (general part)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protractor-styleguide.