Code Monkey home page Code Monkey logo

Comments (2)

CarmenPopoviciu avatar CarmenPopoviciu commented on August 10, 2024

The rule says Declare functions for operations that require more that one step. In that example, the function contained just one step, thus making it redundant to add an extra wrapper function. I don't see how the example was incorrect.

Withe these changes, the recommended example goes against the statement of the rule

from protractor-styleguide.

yadimon avatar yadimon commented on August 10, 2024

One line may be more then 1 step.
user.name.sendKeys('TeddyB'); means select name field, and send keys parameter
its like 2 steps.
For example if the logic : input name, will be more complex (name in form is not a good example, but let say is will be more complex somehow), you will need to change all places where you used this 'double step' line. With a special function for the logic its just a function content change.

btw. the function enterName should return the statement, in case the user of such function want to use promises etc.

and even if my PR were wrong, then the rule description should be like dont use function for one line code. Because it is what the code shows. Use function for more than one step is not represented in the example. So its probably just inverted and my PR is right :)

from protractor-styleguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.