Adding corretto-maven images based on Debian about docker-maven HOT 10 CLOSED

For context -- at Slack we are using something similar to the addition I'm proposing and we'd like to contribute it back here for general availability.

from docker-maven.

hi, isn't amazon willing to provide a corretto debian variant?
Putting it here may be ok, but it adds extra maintenance and it is possible that it cannot be published to the official dockerhub registry, just my personal ones, would need to check with Dockerhub maintainers.

from docker-maven.

Thank you for the quick response. That's a good question -- I asked here whether there's plans to publish the Debian based corretto images & if so whether they can be updated to track debian:stable-slim rather than debian:buster-slim -- corretto/corretto-docker#140.

Putting this here for the case that they do not want to provide a Debian based Corretto image:

• I 100% agree that having them here (without an upstream Corretto Debian image) puts extra maintenance burden on this repo. But for what it's worth, in my opinion the maintenance burden would be fairly small considering the steps in the Dockerfile before the regular maven install that is done for all the images would just be as simple as:

FROM debian:stable-slim

RUN apt-get update \
  && apt-get dist-upgrade -y \
  && apt-get install curl gnupg -y \
  && apt-get autoremove -y \
  && curl https://apt.corretto.aws/corretto.key | gpg --dearmor | dd of=/usr/share/keyrings/corretto.gpg \
  && echo "deb [signed-by=/usr/share/keyrings/corretto.gpg] https://apt.corretto.aws stable main" > /etc/apt/sources.list.d/corretto.list \
  && apt-get update \
  && apt-get install -y java-17-amazon-corretto-jdk \
  && rm -rf /var/lib/apt/lists/*

# common for all images
<ALL THE COMMON STEPS FOR MAVEN>

• As for not being able to publish such an image to the official dockerhub registry -- would a Maven image that was based on Amazon published Debian corretto (if they were to provide one) be allowed to official dockerhub registry easier? Just trying to confirm my understanding that the barrier to publishing to official dockerhub registry is having the Corretto install in this repo and not Debian in general.

from docker-maven.

I think this can be added here, then it will be submitted to the dockerhub maintainers and see if it is accepted

from docker-maven.

Sounds good, I will make a PR in the coming days then.

from docker-maven.

@carlossg wanted to ask about some of the comments in docker-library/official-images#14308 (comment)

To address the naming & not pinning to a particular debian release, what is your opinion on doing the following -

• Change the corretto debian images to be build from bullseye-slim rather than stable-slim
• Rename them all to just have a debian suffix, rather than debian-slim

I would love to get the debian images in a state that is acceptable to official dockerhub maintainers so let me know what your thoughts are here & I am happy to do the changes that you suggest.

from docker-maven.

IIUC that comment the concern is that there are eclipse-temurin-11-focal and these should be amazoncorretto-11-bullseye or amazoncorretto-11-debian (for stable) or amazoncorretto-11-buster (is buster the current stable?)

the architectures can be filtered in https://github.com/carlossg/docker-maven/blob/main/generate-stackbrew-library.sh#L36-L41

from docker-maven.

Current debian stable is bullseye. IMO at least for now, let's just rename to amazoncorretto-11-debian and inherit from debian:bullseye-slim.

I think renaming the directories to include the release name is IMO going to be more maintenance overhead (because we'll need to regenerate all the workflow .ymls, change any checks for them etc.) when stable release rolls over; we can just add an extra tag for the release name as a suffix instead so people can pin to that if they want to.

If you are OK with my proposal, I can make a PR to do that & also filter the architectures in the same PR.

from docker-maven.

Have gone ahead and made a PR which attempts to address the naming -- #362

from docker-maven.

Just wanted to say thank you much @carlossg for all the time and effort you've spent getting the Debian images onto docker hub! It's much appreciated. With that I will go ahead and close this issue!

from docker-maven.