Provide a minimal example about pp2_didomenico_gigantiello_krishnamurthy HOT 5 OPEN

hi there,
We added a second example without HTML, in this the HTML is generated via javascript.
If you want us to change anything else, just tell us.
kind regards,
Carlo, Enrico, Sai

Date: Tue, 27 Jan 2015 21:37:20 -0800
From: [email protected]
To: [email protected]
Subject: [PP2_DiDomenico_Gigantiello_Krishnamurthy] Provide a minimal example (#1)

Hi there,

it would be great if you could provide a minimal example without the user controls and/or the graph.

All you nice HTML description is meta information and unfortunately useless for someone who wants to reuse your component

BTW you should also remove non-functioning snippets ...

@daviddao

—
Reply to this email directly or view it on GitHub.

                  =

from pp2_didomenico_gigantiello_krishnamurthy.

Hi guys,

It is very nice that you create your "TUM : Technical University of Munich" and so on now dynamically, but actually I was just asking to leave this out and just to show the output with an example sequence.
Reasons: (1) The space at the registry is limited & downloading and (2) then uploading a dummy sequence is not so convenient and (3) probably no one who wants to embed your component is interested in the header.

Sorry for the confusion.

from pp2_didomenico_gigantiello_krishnamurthy.

Basically I thought your example snippet is like this

var xhr = require("xhr");
var parser = require("biojs-io-genbank");
var GenbankVis = require("biojs-vis-genbank");
xhr(<file>, function(err,status,body){
  var data = parser(body);
  var instance = new GenbankVis({el: yourDiv, data: data});
});

As you require your parser in the Visualization and therefore bundle them anyway.

var parser = GenbankVis.parser

(of your then you would need to write module.exports.parser = parseGBF in your index.js)

Also you don't need to use xhr (it is just a tiny module) - jQuery (which you also bundle into your vis) has the $.get method ....

Don't forget to expose modules that you require in a snippet:

package.json

... 
 "sniper": {
...
    "exposed": [
      "biojs-io-fasta",
      "xhr"
    ],
....

from pp2_didomenico_gigantiello_krishnamurthy.

So what I'll do is this: I'll delete the 'first' example with the static html and remove from the second( named 'minimal') all the images leaving only the sequence parsing, no TUM logo and so on. Is this OK?

from pp2_didomenico_gigantiello_krishnamurthy.

I would advise you to load a sequence by default ...

You can keep the static html if you want - just change the property "first" in the "sniper".

Cheers,

Seb

On 2015-01-28 20:18, Carlinho89 wrote:

So what I'll do is this: I'll delete the 'first' example with the static html and remove from the second( named 'minimal') all the images leaving only the sequence parsing, no TUM logo and so on. Is this OK?

---

Reply to this email directly or view it on GitHub:
#1 (comment)

from pp2_didomenico_gigantiello_krishnamurthy.