The way that string length is compared and calculated is not correct when strings have

Do you want to fix this <a class="user-mention notranslate" data-hovercard-type="user"

I don't see why use the Math.max()... I would go this way <div class="snippet-

1.6 Length bug about ctci-6th-edition-javascript HOT 5 OPEN

careercup commented on July 22, 2024

1.6 Length bug

from ctci-6th-edition-javascript.

Comments (5)

heytonytan commented on July 22, 2024 1

Hey @dawsbot, hope you're having a great weekend! Sure thing, I can take care of it :)

…

On Sun, 21 May 2017 at 14:02 Dawson Botsford ***@***.***> wrote: Do you want to fix this @tankwan <https://github.com/tankwan>? I can if not. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEhn5XRlVvasQXycgtMpLJwhFUE1HGjHks5r8KZ_gaJpZM4NhuTU> .

from ctci-6th-edition-javascript.

profnandaa commented on July 22, 2024 1

@thetonytan - ping!

from ctci-6th-edition-javascript.

dawsbot commented on July 22, 2024

Do you want to fix this @tankwan? I can if not.

from ctci-6th-edition-javascript.

yuriaps commented on July 22, 2024

Bug in this test
console.log('aabbcc', strComp('aabbcc'), 'aabbcc')
As the book says, if the length of the result is not less than the original should print the original, and it is printing:
a2b2c2

from ctci-6th-edition-javascript.

yuriaps commented on July 22, 2024

I don't see why use the Math.max()...
I would go this way

var strComp = function(string) {
    var compressed = '';
    var currChar = '';
    var currCount = '';
    for (var i = 0; i < string.length; i++) {
      if (currChar !== string[i]) {
        compressed = compressed + currChar + currCount;
        currChar = string[i];
        currCount = 1;
      } else {
        currCount++;
      }
    }
    compressed = compressed + currChar + currCount;
  
    return compressed.length >= string.length ? string : compressed;
  };

from ctci-6th-edition-javascript.

Related Issues (14)

Recommend Projects