Code Monkey home page Code Monkey logo

Comments (5)

metonym avatar metonym commented on June 15, 2024 1

I'm opposed to this. Props are purposefully listed with the most relevant/important. In the docs, reactive vars are listed first.

Generally, props should be sorted by importance, relevance, then grouped by similarity.

from carbon-components-svelte.

metonym avatar metonym commented on June 15, 2024 1

For example - yes, it's easier to initially find a prop in an alphabetized list, but it's inefficient beyond that.

A prop like hideLabel naturally follows labelText. If alphabetized, hideLabel would appear before labelText.

Props like invalidText and warnText should also be close in proximity.

from carbon-components-svelte.

SimpleProgrammingAU avatar SimpleProgrammingAU commented on June 15, 2024

I alphabetised them in code to make the editing experience easier. This is something I'm gonna want to do before doing the tasks for #1629. Is there a way we can make this an initial step for #1629 without it becoming too painful?

from carbon-components-svelte.

theetrain avatar theetrain commented on June 15, 2024

@metonym fair enough, the rationale is sound. Seeing most-used props first does provide good quality of life to users, myself included. I don't see a way to ensure this ordering via linting or docs generation, but that's ok.

from carbon-components-svelte.

theetrain avatar theetrain commented on June 15, 2024

I added a "Prop ordering" rule in #1621 so that this is captured somewhere. We can continue to discuss ordering in that proposal.

from carbon-components-svelte.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.