Comments (5)
I'm opposed to this. Props are purposefully listed with the most relevant/important. In the docs, reactive vars are listed first.
Generally, props should be sorted by importance, relevance, then grouped by similarity.
from carbon-components-svelte.
For example - yes, it's easier to initially find a prop in an alphabetized list, but it's inefficient beyond that.
A prop like hideLabel naturally follows labelText. If alphabetized, hideLabel would appear before labelText.
Props like invalidText and warnText should also be close in proximity.
from carbon-components-svelte.
I alphabetised them in code to make the editing experience easier. This is something I'm gonna want to do before doing the tasks for #1629. Is there a way we can make this an initial step for #1629 without it becoming too painful?
from carbon-components-svelte.
@metonym fair enough, the rationale is sound. Seeing most-used props first does provide good quality of life to users, myself included. I don't see a way to ensure this ordering via linting or docs generation, but that's ok.
from carbon-components-svelte.
I added a "Prop ordering" rule in #1621 so that this is captured somewhere. We can continue to discuss ordering in that proposal.
from carbon-components-svelte.
Related Issues (20)
- RadioButton checked doesn't change HOT 1
- Button with icon only - always shows tooltip HOT 2
- TooltipIcon memory leak HOT 3
- TextInput v11 HOT 4
- PasswordInput v11 HOT 5
- Layer (new component) HOT 3
- Use `Button` component instead of native `button` in `HeaderGlobalAction` HOT 1
- Popover v11 HOT 5
- Support nested properties in DataTable filtering search HOT 3
- IconButton v11 HOT 1
- DataTable on:click:row is missing target and currentTarget information
- ContextMenu prevents context menu invocations outside of the target HOT 2
- TypeScript cannot find CarbonTheme type when using Theme HOT 5
- `ToastNotification` close event can fire after close due to timeout HOT 1
- Link: do not render `<p>` HOT 2
- Unable to resolve *.js imports HOT 1
- Support minCount in TextArea component HOT 1
- Clean up accessibility warnings
- DataTable sort function return type is restricted to -1, 0 or 1 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carbon-components-svelte.