Code Monkey home page Code Monkey logo

Comments (2)

tombrunet avatar tombrunet commented on July 22, 2024

Adding some info, since this came up on accessibility office hours from another team. It looks like the aria-label is hardcoded and doesn't include the chart name or any identifying information from the chart:

.attr('aria-label', `chart toolbar`)

It looks like someone tried to solve this using a random id, but then had to be pulled again because this solution doesn't account for the fact that these are human consumable string and not programmatic ids: (162e410)

Also related issue: #1728

We need some way to have it be something like ${chart title} toolbar, or provide the user for a way to override the toolbar title in the chart options.

from carbon-charts.

Mahalakshmivignesh avatar Mahalakshmivignesh commented on July 22, 2024

@theiliad - Even after removing the aria-label, i still get the 'Multiple toolbar components do not have unique labels' issue.
I am using the latest charts version 1.19.2 . This is the components HTML <div class="cds--cc--toolbar" width="100%" height="100%" role="toolbar">.

Is there any additional changes to be done to make this error go?

from carbon-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.