Full Screen On Web Issue Redirecting about generic-oauth2 HOT 5 CLOSED

No Problem Here it is!

{
    appId: --
    authorizationBaseUrl: 'https://accounts.google.com/o/oauth2/auth',
    accessTokenEndpoint: 'https://www.googleapis.com/oauth2/v4/token',
    scope: 'email profile https://www.googleapis.com/auth/drive',
    resourceUrl: 'https://www.googleapis.com/userinfo/v2/me',
    web: {
      // redirectUrl: 'http://localhost:8081',
      redirectUrl: 'https://meshmycampus.app',
      windowOptions: 'height=600,left=0,top=0',
    },

Additionally,

In using Safari fully launched, it is opening a new tab rather than a window. It also does this in Chrome 72 in full-screen mode. See video (Shared by Google Drives) attached.

I am also available for a video call to further demonstrate.

Frameworks and Information -
App: 100% Custom Web Components Application (Frameworkless)
OS: macOS Mojave: 10.14.1
Browsers: Chrome 72.0
Safari: 12.0.1

It seems to be good to go on mine But the issue is that on real world devices it throws a 50/50 error as above. Which I am trying to reproduce.

https://drive.google.com/drive/folders/1ocGu2oWiQsl_4AwDQHcMJaVUTN5RQHPD?usp=sharing

from generic-oauth2.

Hey Tsavo!

Could you please share your OAuth2AuthenticateOptions (w/o appId) and your some version numbers of OS, Safari, frameworks and lib.

I guess you do not use the option web.windowOptions.

I tested the master (cap.beta.17) with windowOptions on macOS Mojave and Safari 12.0.2 opens a new window (not a tab) and login with Google and Facebook works.

BR

from generic-oauth2.

Hey, is this still a issue or did you figure it out?

from generic-oauth2.

from generic-oauth2.

I added a new windowTarget option a while ago.

Maybe it helps: https://github.com/moberwasserlechner/capacitor-oauth2/blob/33c041e248d0a18ef491f042336c9dcf36a3bd38/src/definitions.ts#L111.

I'll close the issue and if it gets more important for you we always can reopen it.

from generic-oauth2.