Code Monkey home page Code Monkey logo

Comments (4)

juleq avatar juleq commented on June 6, 2024

Since I do not have sufficient permissions, I cannot label this as enhancement.

from cantools.

karlding avatar karlding commented on June 6, 2024

Would something like this work? @eerimoq I can work on this and submit a PR if you're okay with formatting it like so:

================================= Messages =================================

  ------------------------------------------------------------------------

  Name:       DRIVER_HEARTBEAT
  Id:         0x64
  Length:     1 bytes
  Cycle time: 1000 ms
  Senders:    DRIVER
  Layout:

                          Bit

             7   6   5   4   3   2   1   0
           +---+---+---+---+---+---+---+---+
     B   0 |<-----------------------------x|
     y     +---+---+---+---+---+---+---+---+
     t       +-- DRIVER_HEARTBEAT_cmd
     e

  Signal tree:

    -- {root}
       +-- DRIVER_HEARTBEAT_cmd

  Signal choices:

    DRIVER_HEARTBEAT_cmd
      2 DRIVER_HEARTBEAT_cmd_REBOOT
      1 DRIVER_HEARTBEAT_cmd_SYNC
      0 DRIVER_HEARTBEAT_cmd_NOOP

  ------------------------------------------------------------------------

Or we can talk about other ways of formatting this if you don't like that!

Edit: I just realized that this is probably talking about writing the DBC string to a file, and not the dump subcommand. 🙃

from cantools.

eerimoq avatar eerimoq commented on June 6, 2024

Looks pretty good! Though, I think I prefer the choices in ascending numeric order and four space indentation.

    DRIVER_HEARTBEAT_cmd
        0 DRIVER_HEARTBEAT_cmd_NOOP
        1 DRIVER_HEARTBEAT_cmd_SYNC
        2 DRIVER_HEARTBEAT_cmd_REBOOT

Please continue this discussion in a new issue or in the PR as the proposed change is unrelated to this issue.

from cantools.

eerimoq avatar eerimoq commented on June 6, 2024

VAL_TABLE_ part of version 28.16.0.

from cantools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.